From e9c04f0976ac22b324c87e84c338b9b6b295f26a Mon Sep 17 00:00:00 2001 From: "m::r" Date: Sun, 11 Jan 2026 21:33:42 +0000 Subject: [PATCH] fix(correct): fix times_shown --- app/src/Flags/Controller/FlagsController.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/Flags/Controller/FlagsController.php b/app/src/Flags/Controller/FlagsController.php index b4ab552..0facbb3 100644 --- a/app/src/Flags/Controller/FlagsController.php +++ b/app/src/Flags/Controller/FlagsController.php @@ -173,6 +173,9 @@ public function getStat(#[CurrentUser] $user, AnswerRepository $repository): Res return $this->json($result); } + /** + * @throws FlagsGeneratorException + */ #[Route('/correct', name: 'correct', methods: ['GET', 'OPTIONS'])] public function getRight(#[CurrentUser] $user, AnswerRepository $repository): Response { @@ -181,17 +184,16 @@ public function getRight(#[CurrentUser] $user, AnswerRepository $repository): Re // TODO move this logic to service // OMG rewrite this poop asap foreach ($result as $key => $item) { - $result[$key]['times_shown'] = 0; + $shown = (int) $item['times_shown']; + $result[$key]['times_shown'] = (int) $item['times_shown']; $result[$key]['times_guessed'] = 0; $result[$key]['flag'] = $this->flagsGenerator->getEmojiFlag($item['flagCode'], CodeSet::EXTENDED); $result[$key]['country'] = $this->getCountryName(strtoupper($item['flagCode'])); foreach ($correctResults as $value) { if ($value['flagCode'] === $result[$key]['flagCode']) { - $shown = (int) $result[$key]['times']; $guesses = (int) $value['times']; $result[$key]['rate'] = (int) (round($guesses / $shown, 2) * 100); $result[$key]['times'] = "$guesses/$shown"; - $result[$key]['times_shown'] = $shown; $result[$key]['times_guessed'] = $guesses; break;