Skip to content

Pass BUILD_THREADS args to runner container #152

@idigs

Description

@idigs

Enable passing the following variables to the runner container:

  • BUILD_THREADS
  • BUILD_THREADS_SYSTEM_TEST

For some reason I had a failing unit test on my ISIS runner, and it only passes if I restrict the number of unit tests running in parallel. It's a 64-core machine and it failed with 64 parallel and 60 parallel tests, but passes with 50 parallel tests. thomashampson/mantid_github_actions_test#3.

Now I'm at the point of those failing system tests so can investigate that.

It's this test here that fails:
https://github.com/mantidproject/mantid/blob/b4d934695ddf02bb8418e38392bb152c3def09d8/Framework/LiveData/test/MonitorLiveDataTest.h#L126

I have seen similar behavior before. With 64 core ornl builders, I set BUILD_THREADS=56 and BUILD_THREADS_SYSTEM_TESTS=12

this aligns exactly what we do with the ISIS 32 core ones, where we have BUILD_THREAD=28 and BUILD_THREADS_SYSTEM_TESTS=6

I guess we might want to be able to pass an argument to the github-runner docker container to specify this

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    In progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions