From 4a45aae2a1d67faa1c774239d64989b5cb6945c6 Mon Sep 17 00:00:00 2001 From: Lucas Storti Date: Mon, 15 Apr 2019 13:43:23 -0700 Subject: [PATCH 1/2] Adding entryFile as one of the options for code_push_release_react_action --- README.md | 1 + .../code_push/actions/code_push_release_react_action.rb | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/README.md b/README.md index fd18b17..84e8d28 100644 --- a/README.md +++ b/README.md @@ -70,6 +70,7 @@ target_binary_version | Target binary version for example 1.0.1 | | mandatory | manadtory update or not | | true description | Release description for CodePush | | no description for release no_duplicate_release_error | Specifies whether to return an error if the main bundle is identical to the latest codepush release | | false +entry_file | This specifies the relative path to the app's root/entry JavaScript file. | none dry_run | Print the command that would be run, but don't run it | | false ### Release React action diff --git a/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb b/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb index 121375e..93a81d6 100644 --- a/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb +++ b/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb @@ -26,6 +26,9 @@ def self.run(params) if params[:sourcemap_output] command += "-s #{params[:sourcemap_output]} " end + if params[:entry_file] + command += "-e #{params[:entry_file]} " + end if params[:dry_run] UI.message("Dry run!".red + " Would have run: " + command + "\n") else @@ -113,6 +116,10 @@ def self.available_options is_string: true, optional: true, description: "Specifies path to write sourcemap to") + FastlaneCore::ConfigItem.new(key: :entry_file, + is_string: true, + optional: true, + description: "specifies the relative path to the app's root/entry JavaScript file") ] end From c3eb0e696675ad43352741d3ccbeacbd0eeeb055 Mon Sep 17 00:00:00 2001 From: Lucas Storti Date: Mon, 15 Apr 2019 13:44:31 -0700 Subject: [PATCH 2/2] Fixing read me --- README.md | 2 +- .../code_push/actions/code_push_release_react_action.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 84e8d28..08ff485 100644 --- a/README.md +++ b/README.md @@ -70,7 +70,7 @@ target_binary_version | Target binary version for example 1.0.1 | | mandatory | manadtory update or not | | true description | Release description for CodePush | | no description for release no_duplicate_release_error | Specifies whether to return an error if the main bundle is identical to the latest codepush release | | false -entry_file | This specifies the relative path to the app's root/entry JavaScript file. | none +entry_file | This specifies the relative path to the app's root/entry JavaScript file. | | none dry_run | Print the command that would be run, but don't run it | | false ### Release React action diff --git a/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb b/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb index 93a81d6..d46b507 100644 --- a/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb +++ b/lib/fastlane/plugin/code_push/actions/code_push_release_react_action.rb @@ -115,11 +115,11 @@ def self.available_options FastlaneCore::ConfigItem.new(key: :sourcemap_output, is_string: true, optional: true, - description: "Specifies path to write sourcemap to") + description: "Specifies path to write sourcemap to"), FastlaneCore::ConfigItem.new(key: :entry_file, is_string: true, optional: true, - description: "specifies the relative path to the app's root/entry JavaScript file") + description: "Specifies the relative path to the app's root/entry JavaScript file") ] end