before refactor to use modern nicegui approaches, and nicewidgets

Author: cudmore

readme-dev.md

@@ -21,3 +21,20 @@ uv run python -m kymflow.gui.main
 ```bash
 uv sync --extra test --extra gui
 ```
+
+
+## Run nicegui with environment variables
+
+src/kymflow/gui/main.py has two environment variables to contrtol the nicegui app
+
+`KYMFLOW_GUI_RELOAD`:
+ - 1 will run in reload mode
+ - 0 will not (use for distributing the app)
+
+`KYMFLOW_GUI_NATIVE`:
+ - 1 will run nicegui in a native standalone browser (load folder is flakey!!!)
+ - 0 will run nicegui in a browser (chrome) tab
+
+```
+KYMFLOW_GUI_NATIVE=1 uv run python -m kymflow.gui.main
+```

src/kymflow/core/utils/logging.py

@@ -1,10 +1,12 @@
 """
-Simple, reliable logging utilities for the kymflow project.
+Simple, reliable logging utilities for the kymflow application.
 
-- Configure logging once via `setup_logging(...)` at app startup.
+- Configure logging via `setup_logging(...)` at app startup.
 - Get module-specific loggers via `get_logger(__name__)`.
+- Reconfigure anytime by calling `setup_logging(...)` again.
 
 This uses the *root logger* so it plays nicely with most frameworks.
+Logs automatically go to ~/.kymflow/logs/kymflow.log by default.
 """
 
 from __future__ import annotations
@@ -16,9 +18,6 @@
 from pathlib import Path
 from typing import Optional, Union
 
-# Internal flag to avoid double-configuration
-_CONFIGURED = False
-
 # Store the log file path for retrieval
 _LOG_FILE_PATH: Optional[Path] = None
 
@@ -29,35 +28,39 @@ def _expand_path(path: Union[str, Path]) -> Path:
 
 def setup_logging(
     level: Union[str, int] = "INFO",
-    log_file: Optional[Union[str, Path]] = None,
+    log_file: Optional[Union[str, Path]] = "~/.kymflow/logs/kymflow.log",
     max_bytes: int = 5_000_000,
     backup_count: int = 5,
 ) -> None:
     """
     Configure root logging with console + optional rotating file handler.
 
-    Calling this multiple times is safe; handlers are only added once.
+    Calling this multiple times will reconfigure logging (removes old handlers first).
 
     Parameters
     ----------
     level:
         Logging level for console (e.g. "DEBUG", "INFO").
     log_file:
-        Optional path to a log file. If None, no file handler is added.
+        Path to a log file. Defaults to "~/.kymflow/logs/kymflow.log".
+        Set to None to disable file logging (console only).
     max_bytes:
         Max size in bytes for rotating log file.
     backup_count:
         Number of rotated log files to keep.
     """
-    global _CONFIGURED
-    if _CONFIGURED:
-        return
-
     # Convert string levels like "INFO" to logging.INFO
     if isinstance(level, str):
         level = getattr(logging, level.upper(), logging.INFO)
 
     root = logging.getLogger()
+    
+    # Remove existing handlers to allow reconfiguration
+    # This prevents duplicate handlers while allowing logging to be reconfigured
+    for handler in root.handlers[:]:
+        handler.close()
+        root.removeHandler(handler)
+    
     root.setLevel(level)
 
     # -------- Formatter --------
@@ -87,8 +90,9 @@ def setup_logging(
         file_handler.setLevel(logging.DEBUG)  # capture everything to file
         file_handler.setFormatter(formatter)
         root.addHandler(file_handler)
-
-    _CONFIGURED = True
+    else:
+        # Clear log file path when file logging is disabled
+        _LOG_FILE_PATH = None
 
 
 def get_logger(name: Optional[str] = None) -> logging.Logger:

src/kymflow/v2/core/image.py

@@ -9,7 +9,7 @@
 from PIL import Image
 import matplotlib.cm as cm
 
-from .viewport import KymViewport
+from kymflow.v2.core.viewport import KymViewport
 
 
 @dataclass

src/kymflow/v2/core/roi.py

@@ -7,7 +7,7 @@
 
 import numpy as np
 
-from .image import KymImage
+from kymflow.v2.core.image import KymImage
 
 @dataclass
 class KymRoi:

src/kymflow/v2/core/session.py

@@ -8,9 +8,9 @@
 import numpy as np
 from PIL import Image
 
-from .image import KymImage, array_to_pil
-from .viewport import KymViewport
-from .roi import KymRoiSet, KymRoi
+from kymflow.v2.core.image import KymImage, array_to_pil
+from kymflow.v2.core.viewport import KymViewport
+from kymflow.v2.core.roi import KymRoiSet, KymRoi
 
 
 @dataclass

src/kymflow/v2/gui/nicegui/image_widget.py

@@ -71,7 +71,7 @@ class KymImageWidget:
     def __init__(
         self,
         engine: KymEngine,
-        parent: Optional[ui.element] = None,
+        parent=None,
         edge_tolerance: float = 5.0,
         cmap: str = "gray",
     ) -> None:
@@ -80,8 +80,8 @@ def __init__(
         Args:
             engine: Backend KymEngine instance providing image, viewport, and
                 ROI management.
-            parent: Optional NiceGUI parent element to contain the widget.
-                If None, the widget is created in the current context.
+            parent: Optional NiceGUI container element (e.g. ui.row(), ui.column()).
+                If None, the widget will create its own container div.
             edge_tolerance: Pixel tolerance for hit-testing ROI edges.
             cmap: Name of the Matplotlib colormap used for rendering.
         """
@@ -98,18 +98,22 @@ def __init__(
         self.last_pan_y_full: Optional[float] = None
         self.last_mouse_x_full: Optional[float] = None
         self.last_mouse_y_full: Optional[float] = None
-        self.last_image_update: float = 0.0  # simple throttle; set by caller if needed
+        self.last_image_update: float = 0.0
 
-        # For move operations we keep a copy of the ROI at drag start
         self._orig_roi_dict: Optional[dict] = None
 
         # Logical display size from the engine
         self.DISPLAY_W = self.engine.display_width
         self.DISPLAY_H = self.engine.display_height
 
-        # Build UI elements
-        with (parent or ui) as container:  # noqa: F841 - container unused, but keeps context
-            # Initial rendering of the viewport
+        # Decide which container to use: either a provided parent, or a fresh div
+        if parent is not None:
+            container = parent
+        else:
+            container = ui.element("div").classes("w-full")
+
+        # Build UI elements inside the container
+        with container:
             pil_img = self.engine.render_view_pil(
                 vmin=None,
                 vmax=None,
@@ -124,7 +128,6 @@ def __init__(
                 f"aspect-ratio: {self.engine.image.width} / {self.engine.image.height}; "
                 "object-fit: contain; border: 1px solid #666;"
             )
-            # Use NiceGUI 3.3.1 pattern: on_mouse + generic "wheel" event
             self.interactive.on_mouse(self._on_mouse)
             self.interactive.on("wheel", self._on_wheel)