From 43fe59ecbe64c25598c396bb8278ec9f350c20d3 Mon Sep 17 00:00:00 2001 From: Dylan Kuhn Date: Sun, 16 Jun 2013 16:20:28 -0700 Subject: [PATCH 1/2] Change removed navigationControl to zoomControl and panControl. --- source/mxn.googlev3.core.js | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/source/mxn.googlev3.core.js b/source/mxn.googlev3.core.js index 44ea72c..bf29cb0 100644 --- a/source/mxn.googlev3.core.js +++ b/source/mxn.googlev3.core.js @@ -11,8 +11,8 @@ Mapstraction: { mapTypeId: google.maps.MapTypeId.ROADMAP, mapTypeControl: false, mapTypeControlOptions: null, - navigationControl: false, - navigationControlOptions: null, + zoomControl: false, + zoomControlOptions: null, scrollwheel: false, disableDoubleClickZoom: true }; @@ -37,12 +37,12 @@ Mapstraction: { } if (this.addControlsArgs) { if (this.addControlsArgs.zoom) { - myOptions.navigationControl = true; + myOptions.zoomControl = true; if (this.addControlsArgs.zoom == 'small') { - myOptions.navigationControlOptions = {style: google.maps.NavigationControlStyle.SMALL}; + myOptions.zoomControlOptions = {style: google.maps.ZoomControlStyle.SMALL}; } if (this.addControlsArgs.zoom == 'large') { - myOptions.navigationControlOptions = {style: google.maps.NavigationControlStyle.ZOOM_PAN}; + myOptions.zoomControlOptions = {style: google.maps.ZoomControlStyle.LARGE}; } } if (this.addControlsArgs.map_type) { @@ -143,13 +143,17 @@ Mapstraction: { var myOptions; // remove old controls - // Google has a combined zoom and pan control. - if (args.zoom || args.pan) { + if (args.pan) { + map.setOptions({ panControl: true }); + } + if (args.zoom) { + myOptions = { zoomControl: true }; if (args.zoom == 'large'){ - this.addLargeControls(); + myOptions.zoomControlOptions = {style: google.maps.ZoomControlStyle.LARGE}; } else { - this.addSmallControls(); + myOptions.zoomControlOptions = {style: google.maps.ZoomControlStyle.SMALL}; } + map.setOptions(myOptions); } if (args.scale){ myOptions = { @@ -175,8 +179,8 @@ Mapstraction: { addSmallControls: function() { var map = this.maps[this.api]; var myOptions = { - navigationControl: true, - navigationControlOptions: {style: google.maps.NavigationControlStyle.SMALL} + zoomControl: true, + zoomControlOptions: {style: google.maps.ZoomControlStyle.SMALL} }; map.setOptions(myOptions); @@ -188,8 +192,9 @@ Mapstraction: { addLargeControls: function() { var map = this.maps[this.api]; var myOptions = { - navigationControl: true, - navigationControlOptions: {style:google.maps.NavigationControlStyle.DEFAULT} + zoomControl: true, + zoomControlOptions: {style:google.maps.ZoomControlStyle.LARGE}, + panControl: true }; map.setOptions(myOptions); this.addControlsArgs.pan = true; From 1e77b7f768d83756d980ed54b83fcca8b86a5f2d Mon Sep 17 00:00:00 2001 From: Dylan Kuhn Date: Thu, 20 Jun 2013 17:34:11 -0700 Subject: [PATCH 2/2] The 'large' control option should include a pan control. I believe this is what the former navigationControl option did. --- source/mxn.googlev3.core.js | 1 + 1 file changed, 1 insertion(+) diff --git a/source/mxn.googlev3.core.js b/source/mxn.googlev3.core.js index bf29cb0..80c4363 100644 --- a/source/mxn.googlev3.core.js +++ b/source/mxn.googlev3.core.js @@ -43,6 +43,7 @@ Mapstraction: { } if (this.addControlsArgs.zoom == 'large') { myOptions.zoomControlOptions = {style: google.maps.ZoomControlStyle.LARGE}; + myOptions.panControl = true; } } if (this.addControlsArgs.map_type) {