dimnames-names of DMs and ISMs

[benthestatistician]

As applied to a DenseMatrix, dimnames() returns a list of two character vectors, "treatment" and "control". As applied to an InfinitySparseMatrix, dimnames() returns a list of two character vectors, "treated" and "control". The two lists should have the same two names.

data(nuclearplants)
match_on.examples <- list()
### Propensity score distances.
### Recommended approach:
(aGlm <- glm(pr~.-(pr+cost), family=binomial(), data=nuclearplants))
match_on.examples$ps1 <- match_on(aGlm)
is(match_on.examples$ps1)
## [1] "DenseMatrix" "matrix"      "array"       "structure"   "vector"   
names(dimnames(match_on.examples$ps1))
## [1] "treatment" "control" 

tmp <- nuclearplants$t1
names(tmp) <- rownames(nuclearplants)
absdist <- match_on(tmp, z = nuclearplants$pr,
                  within = exactMatch(pr ~ pt, nuclearplants))
is(absdist)
## [1] "BlockedInfinitySparseMatrix" "InfinitySparseMatrix"       
## [3] "vector"     
names(dimnames(absdist))
## [1] "treated" "control"

[benthestatistician]

1. I prefer c("treatment", "control") over c("treated", "control").
2. Josh I think this will be a minor add on to your sism work under subset.BISM #246, so I hope it's OK if I take the liberty of assigning to you.

[nullsatz]

I replaced 'treated' with 'treatement' anywhere I found it in R/InfinitySparseMatrix.R

Then I ran devtools::check() and used the output to replace 'treated' with 'treatment` in any testthat test that failed or complained.

I did this in the branch ism-treated-treatment

[nullsatz]

I think this work is done and there is a pull request so I'm going to close the issue.