Fix high priority issues and add useDockLayout tests#6
Closed
Conversation
- Fix error thrown on unmounted container during resize by returning early instead of throwing - Add validation for container size to prevent negative dimensions when size <= 0 - Add validation for split ratios to clamp values to 0-1 bounds - Fix useResizeObserver to gracefully handle unattached refs - Add comprehensive test suite for useDockLayout hook (17 tests) - Update existing test to set valid size before resizing
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
early instead of throwing
when size <= 0