code highlight broken for Default Light/Dark+ theme

[Krysl]

vscode-docs-view/src/codeHighlighter.ts

Lines 109 to 111 in dc69f7e

	if (typeof theme === 'string') {
	theme = await shiki.loadTheme(theme as any);
	}

theme will not be load for Default Light+ or Default Dark+, because loadTheme need a path arg, not just a name.

 src/codeHighlighter.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/codeHighlighter.ts b/src/codeHighlighter.ts
index 002d214..d941241 100644
--- a/src/codeHighlighter.ts
+++ b/src/codeHighlighter.ts
@@ -107,7 +107,7 @@ export class CodeHighlighter {
 		}
 
 		if (typeof theme === 'string') {
-			theme = await shiki.loadTheme(theme as any);
+			theme = await shiki.loadTheme(`themes/${theme as any}.json`);
 		}
 
 		if (theme) {

[georglauterbach]

I have the same issue, and it's frustrating. Can this somehow be upstreamed? I saw that your for @Krysl contains some fixes, but I am not sure how much time @mattbierner has to look through them, as the issue tracker appears to be rather unmaintained.

[Krysl]

@georglauterbach

Sorry, I'm a bit busy right now and don't have time to check carefully, but I found the expansion pack I packed a few months ago.

docs-view-0.2.0.vsix.zip

[georglauterbach]

Thanks for the swift response! I'll try it :)

[georglauterbach]

I just noticed that my error is different, sadly. I am using automatic Dark/Light themes (based on the system), and the docsView extension does not pick up the change.