Bootstrap 4 support

[jeevcat]

Is there an easy way to switch over to Bootstrap 4, while using this extension? I understand it's still in Alpha, but I figured it might be something other people might also be interested in.

[mbr]

Unfortunately, I am a bit strapped for time and haven't had a look at Bootstrap 4 yet - I'm waiting for it to be released first. Your best option is a fork to try it out. Usually changing version numbers is straightforward, you'll have to find out yourself how backwards-incompatible the whole thing really is =).

…

On Thu, Jun 29, 2017 at 8:06 PM, Sam Jeeves ***@***.***> wrote: Is there an easy way to switch over to Bootstrap 4, while using this extension? I understand it's still in Alpha, but I figured it might be something other people might also be interested in. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#162>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGv8cCb5-eQC2ZhpDU8-ZUet4BVZM01ks5sI-ebgaJpZM4OJq_Y> .

[jeevcat]

Okay thanks for the reply.

I've forked the repo and managed to get v4.0.0-Alpha.6 working. I had to include Tether.js which is required by Bootstrap 4 for tooltips apparently. I also had to fiddle a little with the versioning regex due to the -alpha-style version numbers.

[cofinley]

@jeevcat If you have something that works, I'd love to check it out on your fork once you push it.

[jeevcat]

I actually already pushed it 2 days ago. Check it out here: https://github.com/jeevcat/flask-bootstrap-4-alpha.

Please let me know if it works for you.

[cofinley]

I was mainly looking for updated wtforms. This is a step in the right direction though. I've updated the forms part on my clone, but kind of towards a side project which may not fall in line with the styling here. Thank you again.

[OverlordQ]

Yeah, the main issue I've found is the WTForms macros will need a heavy overhaul for v4 forms. Otherwise @jeevcat's fork is WFM.

[beenje]

I'll try to make a proper pull request starting from @jeevcat repository.

[beenje]

I just created the pull request #164

[MelleB]

What do we need to push this forward?

[mbr]

I will be looking into this on Sunday. The current blocker is that I want to deprecate quick_forms in favor of the new, dominate-based quick_forms which has *much* more maintaineable code. Otherwise, I would have done this already.

…

On Tue, Apr 10, 2018 at 2:53 PM, Melle ***@***.***> wrote: What do we need to push this forward? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGv8cssD4lh1EOyhmHRQCwAFZTUym2Xks5tnKsugaJpZM4OJq_Y> .

[mbr]

And FWIW, I am sorry for the delay =( On Tue, Apr 10, 2018 at 3:06 PM, Marc Brinkmann <git@marcbrinkmann.de> wrote:

…

I will be looking into this on Sunday. The current blocker is that I want to deprecate quick_forms in favor of the new, dominate-based quick_forms which has *much* more maintaineable code. Otherwise, I would have done this already. On Tue, Apr 10, 2018 at 2:53 PM, Melle ***@***.***> wrote: > What do we need to push this forward? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#162 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAGv8cssD4lh1EOyhmHRQCwAFZTUym2Xks5tnKsugaJpZM4OJq_Y> > . >

[cofinley]

Recent bug I found with the 4.0 branch is that pagination.html needs the appropriate .page-link and .page-item classes.

[mcnullity]

Eagerly waiting...

[joncutrer]

+1