Skip to content

Swapped basename fallback function from os.tempnam to uuid #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-beauchamp merged 5 commits into from
Dec 17, 2025
Merged

Swapped basename fallback function from os.tempnam to uuid #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f10f50
Swapped from depracated fallback file basename to UUID
mhocking2020 Dec 4, 2025
2c6fcd5
Update python version to 3.9
mhocking2020 Dec 11, 2025
8a972fe
Fix version so only ubuntu is on 3.9
mhocking2020 Dec 11, 2025
faa22ec
Move frequent check to 3.9
mhocking2020 Dec 11, 2025
7be6840
New compile args
mhocking2020 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/frequent_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5 # https://github.com/marketplace/actions/setup-python
with:
python-version: '3.7'
python-version: '3.9'
- name: configure
run: |
mkdir target-Release
cd target-Release
cmake .. -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.7
cmake .. -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.9
- name: make
run: |
cd target-Release
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5 # https://github.com/marketplace/actions/setup-python
with:
python-version: '3.7'
python-version: '3.9'
- name: configure
run: |
mkdir target-Release
cd target-Release
cmake -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.7 ..
cmake -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.9 ..
- name: make
run: |
cd target-Release
Expand Down
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ if (${CMAKE_PROJECT_NAME} STREQUAL nitro)
elseif (UNIX)
add_compile_options(-Werror) # warnings as errors

if (CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 10.0)
add_compile_options(-Wno-error=c++20-compat -Wno-error=format-truncation)
endif()

if (ENABLE_ASAN)
# https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html
add_compile_options(-fsanitize=address)
Expand Down
4 changes: 2 additions & 2 deletions modules/python/nitf/samples/nitf_extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"""

from nitf import *
import os, sys, logging, glob
import os, sys, logging, glob, uuid

logging.basicConfig(level=logging.INFO, stream=sys.stdout,
format='%(asctime)s %(levelname)s %(message)s')
Expand All @@ -40,7 +40,7 @@ def extract_image(subheader, index, imageReader, outDir=None, baseName=None):
bandData = imageReader.read(window)

if not outDir: outDir = os.getcwd()
if not baseName: baseName = os.path.basename(os.tempnam())
if not baseName: baseName = os.path.basename(uuid.uuid4().hex)

outNames = []
for band, data in enumerate(bandData):
Expand Down
4 changes: 2 additions & 2 deletions modules/python/nitf/samples/test_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"""

from nitf import *
import os, sys, logging, glob
import os, sys, logging, glob, uuid
from PIL import Image

logging.basicConfig(level=logging.INFO, stream=sys.stdout,
Expand All @@ -41,7 +41,7 @@ def dump_image(subheader, index, imageReader, outDir=None, baseName=None):
bandData = imageReader.read(window)

if not outDir: outDir = os.getcwd()
if not baseName: baseName = os.path.basename(os.tempnam())
if not baseName: baseName = os.path.basename(uuid.uuid4().hex)

outNames = []
for band, data in enumerate(bandData):
Expand Down