Skip to content

Basic working issues #2

@megamaz

Description

@megamaz

When pressing enter, the program gives calls input, so by the time you reach line 296 you've already released the enter key- so you need to press it again in order for it to count as released. The best solution would be to wait for the key's release initially instead of the key being pressed down.

Also, the getpass is to avoid having the enter key instantly cancel out the input. There's probably a better work around than getpass- and I think the best fix would be rewriting the input system to just work better, probably using pynput instead of a while loop to check for key press and release. Not entirely sure but this might fix the issue on line pointed out on line 289.

This would probably fix "Actions working on window minimized" (where minimized means unfocused) as well, though I'm not entirely sure.

For highlighting I'll just have to find another way to check for the byte I'm looking for that doesn't include searching the displayed string... that seems like a hacky way of doing it in the first place. The find wasn't originally meant to act like a "goto" but more like a ctrl+f. Will have to include a "goto next" instead of putting you at the first index of the found content, and scan the file content instead of what's being displayed.

For end of files I'll just have to fix the endIndex variable to not only be multiples of 16.

(also qol for devs; rename variable highlit to highlight. And maybe, just maybe, find some other way of "refreshing" the console without using cls this would make it less "flashy" and easier on the eyes.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions