[ALIGNMENT]: Clients / apps should auto-favorite nodes upon direct-message except for CLIENT_BASE nodes

[thebentern]

Currently I believe we have implemented automatic flavoriting upon DMing another node in all app platforms. This is generally considered desirable behavior as it ensures that the public keys are retained in the nodedb of the device. However, we have one context where this is extremely problematic, which is in the CLIENT_BASE role. In this role, we would be unintentionally creating routing issues for nodes which are not explicitly favorited by the user for relay out of their home base nodes.

• Create Android alignment issue.
• Create iOS alignment issue.
• Create Web alignment issue.

[jamesarich]

@thebentern as i was implementing on android - the current implementation was updated to use the new manually_verified shared contact flow, with a fallback to the favorite-before-dm flow - gated on the fw version that supports manually_verified.

I added the additional check for CLIENT_BASE in the older favoriting flow.

Though, now that I think about it I'm not sure CLIENT_BASE would even be in firmware old enough to not also have manually_verified

tl;dr - this may be moot if you've already updated your pre-dm flow to use the manually_verified shared contact dance.

[aerodan]

In the second case, (favorite-before-dm), the unintended router issue persists I think? Example: A user has favorited a friend's node. Then the same user enables Client_Base and DMs the friend. The check is done and since the node was already favorite it would be impacted by the new, likely poorly situated, roof router they do not control.

More to the use case: DM'ing a user directly should not assume the user wants it as a persistent favorite.