From 8fc77e971cfb0c6103c38872b57667693091c881 Mon Sep 17 00:00:00 2001 From: dcsan Date: Sun, 3 May 2015 20:56:10 -0700 Subject: [PATCH 1/2] fix header bar for android ref #100 --- components/ionHeaderBar/ionHeaderBar.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/components/ionHeaderBar/ionHeaderBar.js b/components/ionHeaderBar/ionHeaderBar.js index ddd7263..abf3826 100644 --- a/components/ionHeaderBar/ionHeaderBar.js +++ b/components/ionHeaderBar/ionHeaderBar.js @@ -3,6 +3,9 @@ IonHeaderBar = { var align = this.alignTitle || 'center'; var $title = this.$('.title'); + //// FIXME this breaks header bar on android devices + //// https://github.com/meteoric/meteor-ionic/issues/100 + //// commenting out at least unbreaks it, but doesn't truly fix it if (Platform.isAndroid() && !this.alignTitle) { $title.addClass('title-left'); return; From da762062eecb53cb2e7dfbd96a2c7cfd3513a374 Mon Sep 17 00:00:00 2001 From: dcsan Date: Sun, 3 May 2015 20:58:05 -0700 Subject: [PATCH 2/2] this isn't a complete fix for #100, but at least its less broken than before. commenting out this code block doesn't appear to break anything and does mean the navbar is now readable. --- components/ionHeaderBar/ionHeaderBar.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/components/ionHeaderBar/ionHeaderBar.js b/components/ionHeaderBar/ionHeaderBar.js index abf3826..6e24686 100644 --- a/components/ionHeaderBar/ionHeaderBar.js +++ b/components/ionHeaderBar/ionHeaderBar.js @@ -6,10 +6,10 @@ IonHeaderBar = { //// FIXME this breaks header bar on android devices //// https://github.com/meteoric/meteor-ionic/issues/100 //// commenting out at least unbreaks it, but doesn't truly fix it - if (Platform.isAndroid() && !this.alignTitle) { - $title.addClass('title-left'); - return; - } + // if (Platform.isAndroid() && !this.alignTitle) { + // $title.addClass('title-left'); + // return; + // } if (align === 'center') { $title.addClass('title-center');