From 5d2d7976d9aad57010bf7d16525e3099b3e53726 Mon Sep 17 00:00:00 2001 From: Salvatore Mendola Date: Mon, 2 May 2022 14:34:08 -0400 Subject: [PATCH 1/3] no transform_keys for bulk import contacts --- lib/active_campaign/faraday/middleware/request.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/active_campaign/faraday/middleware/request.rb b/lib/active_campaign/faraday/middleware/request.rb index dec1dee..cd10960 100644 --- a/lib/active_campaign/faraday/middleware/request.rb +++ b/lib/active_campaign/faraday/middleware/request.rb @@ -37,6 +37,8 @@ def normalize_body(env) logger.debug("Using body as is because group #{body}") elsif body.key?(:list) logger.debug("Using body as is because list #{body}") + elsif body.key?(:contacts) && body.key?(:callback) + logger.debug("Using body as is because contacts+callback #{body}") else body = transform_keys(body, :camelcase, :lower) end From c797ddf3192e254071e633fc1ce69aec6f4c0b2d Mon Sep 17 00:00:00 2001 From: Salvatore Mendola Date: Tue, 7 Jun 2022 16:42:49 -0400 Subject: [PATCH 2/3] Handle: undefined method `status` for # (NoMethodError) --- lib/active_campaign/errors.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/active_campaign/errors.rb b/lib/active_campaign/errors.rb index 6132438..5552dac 100644 --- a/lib/active_campaign/errors.rb +++ b/lib/active_campaign/errors.rb @@ -29,7 +29,7 @@ def message super else <<~MESSAGE - STATUS: #{response.status} + STATUS: #{response.try(:status)} URL: #{env.url} REQUEST HEADERS: #{env.request_headers} RESPONSE_HEADERS: #{env.response_headers} From 75bb12f21d8c72ec036b5f38a352d4c68d5576a5 Mon Sep 17 00:00:00 2001 From: Salvatore Mendola Date: Wed, 7 Sep 2022 12:12:21 -0400 Subject: [PATCH 3/3] even more protection on error message generation --- lib/active_campaign/errors.rb | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/active_campaign/errors.rb b/lib/active_campaign/errors.rb index 5552dac..bf79ac6 100644 --- a/lib/active_campaign/errors.rb +++ b/lib/active_campaign/errors.rb @@ -28,14 +28,18 @@ def message if response.nil? super else - <<~MESSAGE - STATUS: #{response.try(:status)} - URL: #{env.url} - REQUEST HEADERS: #{env.request_headers} - RESPONSE_HEADERS: #{env.response_headers} - REQUEST_BODY: #{env.request_body}\n\n" - RESPONSE_BODY: #{response.body}\n\n" - MESSAGE + begin + <<~MESSAGE + STATUS: #{response.try(:status)} + URL: #{env.url} + REQUEST HEADERS: #{env.request_headers} + RESPONSE_HEADERS: #{env.response_headers} + REQUEST_BODY: #{env.request_body}\n\n" + RESPONSE_BODY: #{response.body}\n\n" + MESSAGE + rescue StandardError => e + super + end end end