onDialogDismiss leaks context

[danvinokour]

I saw that there is a memory leak in onDialogDismiss().
dialog.dismiss wasn't called and therefore a leak accoured.

Maybe you should add the listener before you start animator?

this is how i create the EasyDialog:
EasyDialog easyDialog = new EasyDialog(mContext.get()). setLocationByAttachedView(viewToAttach). setLayout(easyDialogView). setGravity(toolTip.getDirection()). setMatchParent(false). setAnimationAlphaShow(600, 0.0f, 1.0f). setAnimationAlphaDismiss(600, 1.0f, 0.0f);

I guess it because i am using animation.

[michaelye]

@danvinokour Ok,I will check it,thanks~

[danvinokour]

Hi,
Do you have an estimation when you are planning to fix it?
It is pretty important for us..

[michaelye]

@danvinokour So sorry about that,danvinokour,I am very busy recently.I plan to fix it this weekend,ok?

[michaelye]

@danvinokour I test the code,it seems that everything works fine,could you please give me more debug info?
Here is my test code:

View view = this.getLayoutInflater().inflate(R.layout.layout_tip_content_horizontal, null);
Button btnOk = (Button)view.findViewById(R.id.btnOk);
final EasyDialog easyDialog = new EasyDialog(MainActivity.this)
                        .setLocationByAttachedView(btnTopLeft)
                        .setLayout(view)
                        .setGravity(EasyDialog.GRAVITY_BOTTOM)
                        .setMatchParent(false)
                        .setTouchOutsideDismiss(false)
                        .setAnimationAlphaShow(600, 0.0f, 1.0f)
                        .setAnimationAlphaDismiss(600, 1.0f, 0.0f);
                        easyDialog.show();
                btnOk.setOnClickListener(new View.OnClickListener()
                {
                    @Override
                    public void onClick(View v)
                    {
                        easyDialog.dismiss();
                    }
                });

[danvinokour]

Hi,
There is a memory leak.. You can use leak canary to find it.
What happens is if i define animation in EasyDialog and i dismiss the
EasyDialog, you never call dialog.dismiss()..put some break points on
dialog.dismiss() and see that it is bot called.. Therefore the dialog stays
in memory and it has context which means that the activity is also leaked.

On Thu, Mar 3, 2016, 14:52 MichaelYe notifications@github.com wrote:

@danvinokour https://github.com/danvinokour I test the code,it seems
that everything works fine,could you please give me more debug info?
Here is my test code:

View view = this.getLayoutInflater().inflate(R.layout.layout_tip_content_horizontal, null);Button btnOk = (Button)view.findViewById(R.id.btnOk);final EasyDialog easyDialog = new EasyDialog(MainActivity.this)
.setLocationByAttachedView(btnTopLeft)
.setLayout(view)
.setGravity(EasyDialog.GRAVITY_BOTTOM)
.setMatchParent(false)
.setTouchOutsideDismiss(false)
.setAnimationAlphaShow(600, 0.0f, 1.0f)
.setAnimationAlphaDismiss(600, 1.0f, 0.0f);
easyDialog.show();
btnOk.setOnClickListener(new View.OnClickListener()
{
@OverRide
public void onClick(View v)
{
easyDialog.dismiss();
}
});

—
Reply to this email directly or view it on GitHub
#25 (comment)
.