Merged PR 229864: Release version 2.19.1 - Scrub config

Remove `accessToken` from the config when throwing an exception.

### Notes for reviewers
- Spread operator seems to be [well supported](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax), doesn't work in IE however it was transplied to `__assign` in JS Code
- I can't put it in `utils.ts` because that would create a circular dependency (with `embed.ts` due to type imports).

Author: Shahak Yosef

dist/powerbi-client.d.ts

@@ -1,4 +1,4 @@
-// powerbi-client v2.19.0
+// powerbi-client v2.19.1
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 declare module "config" {
@@ -191,11 +191,11 @@ declare module "embed" {
          */
         eventHandlers: IInternalEventHandler<any>[];
         /**
-        * Gets or sets the eventHooks.
-        *
-        * @type {models.EventHooks}
-        * @hidden
-        */
+         * Gets or sets the eventHooks.
+         *
+         * @type {models.EventHooks}
+         * @hidden
+         */
         eventHooks: models.EventHooks;
         /**
          * Gets or sets the Power BI embed service.

dist/powerbi.js

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-client",
-  "version": "2.19.0",
+  "version": "2.19.1",
   "description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
   "main": "dist/powerbi.js",
   "types": "dist/powerbi-client.d.ts",

dist/powerbi.min.js

@@ -3,7 +3,7 @@
 
 /** @ignore *//** */
 const config = {
-  version: '2.19.0',
+  version: '2.19.1',
   type: 'js'
 };
 

package.json

@@ -109,11 +109,11 @@ export abstract class Embed {
   eventHandlers: IInternalEventHandler<any>[];
 
   /**
-  * Gets or sets the eventHooks.
-  *
-  * @type {models.EventHooks}
-  * @hidden
-  */
+   * Gets or sets the eventHooks.
+   *
+   * @type {models.EventHooks}
+   * @hidden
+   */
   eventHooks: models.EventHooks;
 
   /**

src/config.ts

@@ -399,7 +399,8 @@ export class Service implements IService {
   private embedNew(element: IPowerBiElement, config: IComponentEmbedConfiguration | IEmbedConfigurationBase, phasedRender?: boolean, isBootstrap?: boolean): Embed {
     const componentType = config.type || element.getAttribute(Embed.typeAttribute);
     if (!componentType) {
-      throw new Error(`Attempted to embed using config ${JSON.stringify(config)} on element ${element.outerHTML}, but could not determine what type of component to embed. You must specify a type in the configuration or as an attribute such as '${Embed.typeAttribute}="${Report.type.toLowerCase()}"'.`);
+      const scrubbedConfig = { ...config, accessToken: "" };
+      throw new Error(`Attempted to embed using config ${JSON.stringify(scrubbedConfig)} on element ${element.outerHTML}, but could not determine what type of component to embed. You must specify a type in the configuration or as an attribute such as '${Embed.typeAttribute}="${Report.type.toLowerCase()}"'.`);
     }
 
     // Saves the type as part of the configuration so that it can be referenced later at a known location.
@@ -429,7 +430,8 @@ export class Service implements IService {
   private embedExisting(element: IPowerBiElement, config: IComponentEmbedConfiguration | IEmbedConfigurationBase, phasedRender?: boolean): Embed {
     const component = utils.find((x) => x.element === element, this.embeds);
     if (!component) {
-      throw new Error(`Attempted to embed using config ${JSON.stringify(config)} on element ${element.outerHTML} which already has embedded component associated, but could not find the existing component in the list of active components. This could indicate the embeds list is out of sync with the DOM, or the component is referencing the incorrect HTML element.`);
+      const scrubbedConfig = { ...config, accessToken: "" };
+      throw new Error(`Attempted to embed using config ${JSON.stringify(scrubbedConfig)} on element ${element.outerHTML} which already has embedded component associated, but could not find the existing component in the list of active components. This could indicate the embeds list is out of sync with the DOM, or the component is referencing the incorrect HTML element.`);
     }
 
     // TODO: Multiple embedding to the same iframe is not supported in QnA
@@ -457,8 +459,8 @@ export class Service implements IService {
 
         return report;
       }
-
-      throw new Error(`Embedding on an existing element with a different type than the previous embed object is not supported.  Attempted to embed using config ${JSON.stringify(config)} on element ${element.outerHTML}, but the existing element contains an embed of type: ${this.config.type} which does not match the new type: ${config.type}`);
+      const scrubbedConfig = { ...config, accessToken: "" };
+      throw new Error(`Embedding on an existing element with a different type than the previous embed object is not supported.  Attempted to embed using config ${JSON.stringify(scrubbedConfig)} on element ${element.outerHTML}, but the existing element contains an embed of type: ${this.config.type} which does not match the new type: ${config.type}`);
     }
 
     component.populateConfig(config, /* isBootstrap */ false);