Bug: `winrt::box_value(std::wstring_view(...))` may cause abort

[justanotheranonymoususer]

Version

No response

Summary

I'm bitten by this for the second time, and it's not pleasant to debug. I have code like:

Blabla(winrt::box_value(GetStringView(...)));

It seems that if GetStringView returns std::wstring_view which happens to end with a null terminator, it works, but if not, then abort is called and the app crashes.

Ideally it should just work correctly. Less ideally, it shouldn't compile without an explicit hstring(...) conversion. Even less ideally, it should always crash. But now, it crashes only in the less common cases, which bits me in the most inconvenient times.

I don't have an isolated repro right now, I'm working on a large codebase, let me know if you need one.

Reproducible example

Expected behavior

No response

Actual behavior

No response

Additional comments

No response

[justanotheranonymoususer]

Offending code:

cppwinrt/strings/base_string.h

Lines 112 to 120 in 1ccb7e1

	inline void create_hstring_on_stack(hstring_header& header, wchar_t const* value, uint32_t length) noexcept
	{
	WINRT_ASSERT(value);
	WINRT_ASSERT(length != 0);
	if (value[length] != 0)
	{
	abort();
	}