chore: remove usage of "export *" #33448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

layershifter merged 2 commits into microsoft:master from layershifter:chore/remove-export-star-p3

Dec 20, 2024

apps/vr-tests-react-components/src/utilities/index.ts

-Original file line number
+Diff line change
@@ -1,3 +1,9 @@
-    export * from './TestWrapperDecorator';
-    export * from './getStoryVariant';
-    export * from './withStoryWrightSteps';
+    export {
+      TestWrapperDecorator,
+      TestWrapperDecoratorFixedWidth,
+      TestWrapperDecoratorFullWidth,
+      TestWrapperDecoratorTall,
+      TestWrapperDecoratorTallFixedWidth,
+    } from './TestWrapperDecorator';
+    export { DARK_MODE, HIGH_CONTRAST, RTL, getStoryVariant } from './getStoryVariant';
+    export { withStoryWrightSteps } from './withStoryWrightSteps';

change/@fluentui-codemods-64d49103-6d6d-4ef0-93f0-2339233931e5.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+      "type": "patch",
+      "comment": "chore: remove usage of \"export *\"",
+      "packageName": "@fluentui/codemods",
+      "email": "olfedias@microsoft.com",
+      "dependentChangeType": "patch"
+    }

change/@fluentui-eslint-plugin-75e61142-a4e1-4046-9076-316b44c873ca.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+      "type": "patch",
+      "comment": "chore: remove usage of \"export *\"",
+      "packageName": "@fluentui/eslint-plugin",
+      "email": "olfedias@microsoft.com",
+      "dependentChangeType": "patch"
+    }

change/@fluentui-react-conformance-33c0a62b-e18c-45a1-9fbd-bfd7089f997c.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+      "type": "patch",
+      "comment": "chore: remove usage of \"export *\"",
+      "packageName": "@fluentui/react-conformance",
+      "email": "olfedias@microsoft.com",
+      "dependentChangeType": "patch"
+    }

change/@fluentui-react-icon-provider-a7f6eac5-5e7c-40b4-ae8c-4b3dab5bc372.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+      "type": "patch",
+      "comment": "chore: remove usage of \"export *\"",
+      "packageName": "@fluentui/react-icon-provider",
+      "email": "olfedias@microsoft.com",
+      "dependentChangeType": "patch"
+    }

change/@fluentui-theme-576e3635-ea2b-48cd-b8bd-f35566e66189.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+      "type": "patch",
+      "comment": "chore: remove usage of \"export *\"",
+      "packageName": "@fluentui/theme",
+      "email": "olfedias@microsoft.com",
+      "dependentChangeType": "patch"
+    }

packages/a11y-testing/src/definitions/index.ts

-Original file line number
+Diff line change
@@ -1,12 +1,25 @@
-    export * from './Button/buttonBehaviorDefinition';
-    export * from './Button/buttonGroupBehaviorDefinition';
-    export * from './Button/toggleButtonBehaviorDefinition';
-    export * from './Link/linkBehaviorDefinition';
-    export * from './MenuButton/menuButtonBehaviorDefinition';
-    export * from './Pill/pillActionBehaviorDefinition';
-    export * from './Pill/pillBehaviorDefinition';
-    export * from './Pill/pillOptionBehaviorDefinition';
-    export * from './Pill/pillGroupBehaviorDefinition';
-    export * from './Popup/popupBehaviorDefinition';
-    export * from './react-button/buttonAccessibilityBehaviorDefinition';
+    export { buttonBehaviorDefinition } from './Button/buttonBehaviorDefinition';
+    export { buttonGroupBehaviorDefinition } from './Button/buttonGroupBehaviorDefinition';
+    export { toggleButtonBehaviorDefinition } from './Button/toggleButtonBehaviorDefinition';
+    export { linkBehaviorDefinition } from './Link/linkBehaviorDefinition';
+    export {
+      menuButtonBehaviorDefinition,
+      menuButtonBehaviorDefinitionMenuSlot,
+      menuButtonBehaviorDefinitionMenuSlotWithoutID,
+      menuButtonBehaviorDefinitionTriggerSlotNotTabbable,
+      menuButtonBehaviorDefinitionTriggerSlotTabbable,
+      menuButtonBehaviorDefinitionTriggerSlotWithoutID,
+      menuButtonBehaviorDefinitionTriggerWithTabIndex,
+    } from './MenuButton/menuButtonBehaviorDefinition';
+    export { pillActionBehaviorDefinition } from './Pill/pillActionBehaviorDefinition';
+    export { pillBehaviorDefinition } from './Pill/pillBehaviorDefinition';
+    export { pillOptionBehaviorDefinition } from './Pill/pillOptionBehaviorDefinition';
+    export { pillGroupBehaviorDefinition } from './Pill/pillGroupBehaviorDefinition';
+    export {
+      popupBehaviorDefinition,
+      popupBehaviorDefinitionPopupSlot,
+      popupBehaviorDefinitionTriggerSlotNotTabbable,
+      popupBehaviorDefinitionTriggerSlotTabbable,
+      popupBehaviorDefinitionTriggerSlotWithTabIndex,
+    } from './Popup/popupBehaviorDefinition';
+    export { buttonAccessibilityBehaviorDefinition } from './react-button/buttonAccessibilityBehaviorDefinition';

packages/a11y-testing/src/facades/index.ts

Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export * from './ComponentTestFacade';
		export { ComponentTestFacade } from './ComponentTestFacade';

packages/a11y-testing/src/index.ts

-Original file line number
+Diff line change
@@ -1,5 +1,27 @@
-    export * from './types';
-    export * from './validators/index';
-    export * from './facades/index';
-    export * from './rules/index';
-    export * from './definitions/index';
+    export type { AccessibilityBehavior, PropValue, Props, Rule, Slot, TestFacade } from './types';
+    export { validateBehavior, validateSlot } from './validators/index';
+    export { ComponentTestFacade } from './facades/index';
+    export { BehaviorRule, SlotRule } from './rules/index';
+    export {
+      buttonAccessibilityBehaviorDefinition,
+      buttonBehaviorDefinition,
+      buttonGroupBehaviorDefinition,
+      linkBehaviorDefinition,
+      menuButtonBehaviorDefinition,
+      menuButtonBehaviorDefinitionMenuSlot,
+      menuButtonBehaviorDefinitionMenuSlotWithoutID,
+      menuButtonBehaviorDefinitionTriggerSlotNotTabbable,
+      menuButtonBehaviorDefinitionTriggerSlotTabbable,
+      menuButtonBehaviorDefinitionTriggerSlotWithoutID,
+      menuButtonBehaviorDefinitionTriggerWithTabIndex,
+      pillActionBehaviorDefinition,
+      pillBehaviorDefinition,
+      pillGroupBehaviorDefinition,
+      pillOptionBehaviorDefinition,
+      popupBehaviorDefinition,
+      popupBehaviorDefinitionPopupSlot,
+      popupBehaviorDefinitionTriggerSlotNotTabbable,
+      popupBehaviorDefinitionTriggerSlotTabbable,
+      popupBehaviorDefinitionTriggerSlotWithTabIndex,
+      toggleButtonBehaviorDefinition,
+    } from './definitions/index';

packages/a11y-testing/src/rules/index.ts

Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export * from './rules';
		export { BehaviorRule, SlotRule } from './rules';

packages/a11y-testing/src/validators/index.ts

Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export * from './validate';
		export { validateBehavior, validateSlot } from './validate';

packages/codemods/src/codeMods/tests/mock/compat/mockIndex.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,2 +1,2 @@
  
    export * from './Button';

    export * from './DefaultButton';

    export { Button, OtherButton } from './Button';

    export { DefaultButton } from './DefaultButton';

packages/codemods/src/codeMods/utilities/index.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,4 +1,4 @@
  
    export * from './jsx';

    export * from './imports';

    export * from './props';

    export * from './transforms';

    export { findJsxTag } from './jsx';

    export { appendOrCreateNamedImport, getImportsByPath, renameImport, repathImport } from './imports';

    export { renameProp } from './props';

    export { boolTransform, enumTransform, numberTransform, stringTransform } from './transforms';

packages/eslint-plugin/src/configs/base.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -19,10 +19,9 @@ module.exports = { @@
       },
       overrides: [
         {
-          files: '**/src/index.{ts,tsx,js}',
+          files: '**/src/**/*.{ts,tsx,js}',
           rules: {
-            // TODO: propagate to `error` once all packages barrel files have been fixed
-            '@rnx-kit/no-export-all': ['warn', { expand: 'all' }],
+            '@rnx-kit/no-export-all': ['error', { expand: 'all' }],
           },
         },
       ],
@@ Expand Down @@

packages/react-components/theme-designer/src/colors/index.ts

-Original file line number
+Diff line change
@@ -1,5 +1,74 @@
-    export * from './csswg';
-    export * from './geometry';
-    export * from './palettes';
-    export * from './templates';
-    export * from './types';
+    export {
+      D50_to_D65,
+      D65_to_D50,
+      LAB_to_sRGB,
+      LCH_to_Lab,
+      LCH_to_P3,
+      LCH_to_r2020,
+      LCH_to_sRGB,
+      Lab_to_LCH,
+      Lab_to_XYZ,
+      P3_to_LCH,
+      XYZ_to_Lab,
+      XYZ_to_lin_2020,
+      XYZ_to_lin_P3,
+      XYZ_to_lin_ProPhoto,
+      XYZ_to_lin_a98rgb,
+      XYZ_to_lin_sRGB,
+      XYZ_to_uv,
+      XYZ_to_xy,
+      contrast,
+      gam_2020,
+      gam_P3,
+      gam_ProPhoto,
+      gam_a98rgb,
+      gam_sRGB,
+      hslToRgb,
+      hueToChannel,
+      lin_2020,
+      lin_2020_to_XYZ,
+      lin_P3,
+      lin_P3_to_XYZ,
+      lin_ProPhoto,
+      lin_ProPhoto_to_XYZ,
+      lin_a98rgb,
+      lin_a98rgb_to_XYZ,
+      lin_sRGB,
+      lin_sRGB_to_XYZ,
+      naive_CMYK_to_sRGB,
+      naive_sRGB_to_CMYK,
+      r2020_to_LCH,
+      rgbToHsv,
+      sRGB_to_LAB,
+      sRGB_to_LCH,
+      sRGB_to_luminance,
+      snap_into_gamut,
+      xy_to_uv,
+    } from './csswg';
+    export { getPointOnCurvePath, getPointsOnCurvePath } from './geometry';
+    export {
+      Lab_to_hex,
+      curvePathFromPalette,
+      hexColorsFromPalette,
+      hex_to_LCH,
+      hex_to_sRGB,
+      paletteShadesFromCurve,
+      sRGB_to_hex,
+    } from './palettes';
+    export { paletteTemplate, themeTemplate } from './templates';
+    export type {
+      Curve,
+      CurvePath,
+      CurvedHelixPath,
+      NamedPalette,
+      NamedTheme,
+      Palette,
+      PaletteConfig,
+      Theme,
+      ThemeCollectionInclude,
+      TokenPackageConfig,
+      TokenPackageType,
+      Vec2,
+      Vec3,
+      Vec4,
+    } from './types';

packages/react-conformance/src/utils/index.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,4 +1,4 @@
  
    export * from './errorMessages';

    export * from './getCallbackArguments';

    export { errorMessageColors, getErrorMessage, formatErrors, formatArray } from './errorMessages';

    export { type ArgumentName, getCallbackArguments } from './getCallbackArguments';

    export { getPackagePath } from './getPackagePath';

    export * from './validateCallbackArguments';

    export { validateCallbackArguments } from './validateCallbackArguments';

packages/react-icon-provider/src/index.ts

-Original file line number
+Diff line change
@@ -1,4 +1,9 @@
     import './version';
-    export * from './IconProvider';
-    export * from './IconProvider.types';
+    export {
+      // eslint-disable-next-line @fluentui/ban-context-export
+      IconContext,
+      IconProvider,
+      useIconSubset,
+    } from './IconProvider';
+    export type { IconProviderProps } from './IconProvider.types';

packages/storybook/src/decorators/index.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,2 +1,2 @@
  
    export * from './withKeytipLayer';

    export * from './withStrictMode';

    export { KeytipLayerWrapper, withKeytipLayer } from './withKeytipLayer';

    export { withStrictMode } from './withStrictMode';

packages/theme/src/colors/index.ts

-Original file line number
+Diff line change
@@ -1,2 +1,2 @@
-    export * from './FluentColors';
+    export { CommunicationColors, NeutralColors, SharedColors } from './FluentColors';
     export { DefaultPalette } from './DefaultPalette';

packages/theme/src/createTheme.test.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,7 @@ describe('createTheme', () => { @@
       it('applies defaultFontStyle to fonts and retains all other default values', () => {
         const defaultFontStyle: IRawStyle = { fontFamily: 'Segoe UI' };
-        const userTheme = { defaultFontStyle: defaultFontStyle };
+        const userTheme = { defaultFontStyle };
         const newTheme = createTheme(userTheme);
         expect(newTheme.fonts.tiny.fontFamily).toEqual('Segoe UI');
@@ Expand All / @@ -38,7 +38,7 @@ describe('createTheme', () => { @@
       it('applies defaultFontStyle and fonts to theme and retains all other default values', () => {
         const defaultFontStyle: IRawStyle = { fontFamily: 'Foo', fontSize: '10px' };
-        const userTheme = { defaultFontStyle: defaultFontStyle, fonts: { small: { fontSize: '20px' } } };
+        const userTheme = { defaultFontStyle, fonts: { small: { fontSize: '20px' } } };
         const newTheme = createTheme(userTheme);
         expect(newTheme.fonts.tiny.fontFamily).toEqual('Foo');
@@ Expand Down @@

packages/theme/src/fonts/createFontStyles.ts

-Original file line number
+Diff line change
@@ Expand Up @@
     function _createFont(size: string, weight: IFontWeight, fontFamily: string): IRawStyle {
       return {
-        fontFamily: fontFamily,
+        fontFamily,
         MozOsxFontSmoothing: 'grayscale',
         WebkitFontSmoothing: 'antialiased',
         fontSize: size,
@@ Expand Down @@

packages/theme/src/fonts/index.ts

-Original file line number
+Diff line change
@@ -1,3 +1,3 @@
-    export * from './FluentFonts';
+    export { FontSizes, FontWeights, IconFontSizes, LocalizedFontFamilies, LocalizedFontNames } from './FluentFonts';
     export { createFontStyles } from './createFontStyles';
     export { DefaultFontStyles, registerDefaultFontFaces } from './DefaultFontStyles';

packages/theme/src/index.ts

-Original file line number
+Diff line change
@@ -1,11 +1,37 @@
-    export * from './mergeThemes';
-    export * from './types/index';
-    export * from './colors/index';
-    export * from './effects/index';
-    export * from './spacing/index';
-    export * from './motion/index';
-    export * from './fonts/index';
-    export * from './createTheme';
+    export { mergeThemes } from './mergeThemes';
+    export type {
+      ComponentStyles,
+      ComponentsStyles,
+      IAnimationStyles,
+      IAnimationVariables,
+      IEffects,
+      IFontStyles,
+      IPalette,
+      IPartialTheme,
+      IScheme,
+      ISchemeNames,
+      ISemanticColors,
+      ISemanticTextColors,
+      ISpacing,
+      ITheme,
+      PartialTheme,
+      Theme,
+    } from './types/index';
+    export { CommunicationColors, DefaultPalette, NeutralColors, SharedColors } from './colors/index';
+    export { DefaultEffects, Depths } from './effects/index';
+    export { DefaultSpacing } from './spacing/index';
+    export { AnimationStyles, AnimationVariables, MotionAnimations, MotionDurations, MotionTimings } from './motion/index';
+    export {
+      DefaultFontStyles,
+      FontSizes,
+      FontWeights,
+      IconFontSizes,
+      LocalizedFontFamilies,
+      LocalizedFontNames,
+      createFontStyles,
+      registerDefaultFontFaces,
+    } from './fonts/index';
+    export { createTheme } from './createTheme';
     export { FluentTheme } from './FluentTheme';
     import './version';

packages/theme/src/motion/index.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,2 +1,2 @@
  
    export * from './FluentMotion';

    export * from './AnimationStyles';

    export { MotionAnimations, MotionDurations, MotionTimings } from './FluentMotion';

    export { AnimationStyles, AnimationVariables } from './AnimationStyles';

packages/theme/src/types/index.ts

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
-    export * from './Theme';
+    export type { ComponentStyles, ComponentsStyles, PartialTheme, Theme } from './Theme';
     export type { IEffects } from './IEffects';
     export type { IFontStyles } from './IFontStyles';
     export type { IPalette } from './IPalette';
@@ Expand Down @@

scripts/dangerjs/src/detectNonApprovedDependencies/utils/index.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,5 +1,5 @@
  
    export { default as getVersionConstraints } from './getVersionConstraints';

    export { default as getRuntimeDependencies } from './getRuntimeDependencies';

    export { default as getFailedPackageVersionConstraints } from './getFailedPackageVersionConstraints';

    export * from './getFailedPackageVersionConstraints';

    export * from './packageNameUtils';

    export type { FailedConstraintsExplanation } from './getFailedPackageVersionConstraints';

    export { getPackageName, getPackageVersion } from './packageNameUtils';

scripts/github/src/index.ts

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
-    export * from './constants';
-    export * from './pullRequests';
-    export * from './types';
+    export { fluentRepoDetails } from './constants';
+    export type { IGetPullRequestFromCommitParams } from './pullRequests';
+    export { getPullRequestForCommit, processPullRequestApiResponse } from './pullRequests';
+    export type { IPullRequest, IRepoDetails, IUser } from './types';

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove usage of "export *" #33448

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!