-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
type:breaking-changeAn issue that will result in dependent client projects failing.An issue that will result in dependent client projects failing.type:bugA broken experienceA broken experience
Description
The implementations for send_primitive and send_collection_of_primitive_async is inconsistent.
If you take a look at the implementation for send_primitive, you'll see that it expects string literals.
However, the implementation for send_collection_of_primitive_async expects types, so making them consistent would be the breaking change.
At the next major version we should change the implementation of send_primitive to take a type parameter instead rather than string literals. This will enable better type validation and more accurate static analysis of parameter passed into the function
Metadata
Metadata
Assignees
Labels
type:breaking-changeAn issue that will result in dependent client projects failing.An issue that will result in dependent client projects failing.type:bugA broken experienceA broken experience
Type
Projects
Status
New📃