Skip to content

fix(TypeScript): use import type for enum types #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gavinbarron merged 4 commits into from
Jan 29, 2026
+32 −0
Merged

fix(TypeScript): use import type for enum types #7332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f6592a
fix(TypeScript): use import type for enum types
kwestground Jan 27, 2026
115a00f
Merge branch 'main' into fix/typescript-enum-import-type
kwestground Jan 28, 2026
e36ccb5
Update changelog: Fix TypeScript enum imports for type aliases
kwestground Jan 28, 2026
9e5251c
Merge branch 'main' into fix/typescript-enum-import-type
baywet Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Fixed TypeScript enum imports to use `import type` for type aliases to support `verbatimModuleSyntax`. [#7332](https://github.com/microsoft/kiota/pull/7332)

## [1.30.0] - 2026-01-26

### Added
Expand Down
4 changes: 4 additions & 0 deletions src/Kiota.Builder/Writers/TypeScript/CodeUsingWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ private static bool GetShouldUseTypeImport(CodeUsing codeUsing)
if (codeUsing.Declaration is CodeType codeType)
{
if (codeType.TypeDefinition is CodeInterface) return true;
// Enums are generated as TypeScript type aliases (e.g., `export type MyEnum = ...`),
// so they must use `import type` for compatibility with verbatimModuleSyntax.
// See: https://github.com/microsoft/kiota/issues/2959
if (codeType.TypeDefinition is CodeEnum) return true;
// this will handle edge cases for typescript Declarations that are already known to be interfaces: RequestConfiguration, QueryParameters, and Model classes
if (codeType.TypeDefinition is CodeClass codeClass && codeClass.IsOfKind(CodeClassKind.RequestConfiguration, CodeClassKind.QueryParameters, CodeClassKind.Model)) return true;
}
Expand Down
26 changes: 26 additions & 0 deletions tests/Kiota.Builder.Tests/Writers/TypeScript/CodeUsingWriterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,4 +188,30 @@ public void WritesImportTypeStatementForModel()
Assert.Contains("// @ts-ignore", result);
Assert.Contains("import { type Bar } from", result);
}

[Fact]
public void WritesImportTypeStatementForEnum()
{
// Enums are generated as TypeScript type aliases (e.g., `export type MyEnum = ...`),
// so they must use `import type` for compatibility with verbatimModuleSyntax.
// See: https://github.com/microsoft/kiota/issues/2959
var usingWriter = new CodeUsingWriter("foo");
var codeEnum = root.AddEnum(new CodeEnum
{
Name = "MyStatus",
}).First();
var us = new CodeUsing
{
Name = "MyStatus",
Declaration = new CodeType
{
Name = codeEnum.Name,
TypeDefinition = codeEnum,
}
};
usingWriter.WriteCodeElement(new CodeUsing[] { us }, root, writer);
var result = tw.ToString();
Assert.Contains("// @ts-ignore", result);
Assert.Contains("import { type MyStatus } from", result);
}
}
Loading