From 0c505c7f03167b6a7a75991f9576ec2124818f01 Mon Sep 17 00:00:00 2001 From: Beabhi17 <134540249+Beabhi17@users.noreply.github.com> Date: Fri, 4 Jul 2025 02:24:44 -0700 Subject: [PATCH 1/7] Update PowerBILoggerTests.cs --- .../Commands.Common.Test/PowerBILoggerTests.cs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index 81338cb8..6adcfc04 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -31,6 +31,17 @@ public void TestDetectingIsPowerBICmdlet() Assert.IsNull(logger.GetPowerBICmdlet); } + [TestMethod] + public void TestWriteWarningAddsMessage() + { + var logger = new PowerBILoggerMock(); + string warning = "This is a warning!"; + logger.WriteWarning(warning); + + Assert.AreEqual(1, logger.WarningMessages.Count); + Assert.AreEqual(warning, logger.WarningMessages[0]); + } + [TestMethod] public void TestMainThreadDetection() { @@ -105,4 +116,4 @@ public override void ExecuteCmdlet() // Nothing } } -} \ No newline at end of file +} From 286ab5b07f3db79e66dbfff6c0f34d594694526a Mon Sep 17 00:00:00 2001 From: Beabhi17 <134540249+Beabhi17@users.noreply.github.com> Date: Sat, 5 Jul 2025 14:07:37 -0700 Subject: [PATCH 2/7] Update PowerBILoggerTests.cs --- src/Common/Commands.Common.Test/PowerBILoggerTests.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index 6adcfc04..4a9819b8 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -34,7 +34,11 @@ public void TestDetectingIsPowerBICmdlet() [TestMethod] public void TestWriteWarningAddsMessage() { - var logger = new PowerBILoggerMock(); + var logger = new PowerBILoggerMock() + { + Cmdlet = new NonPowerBICmdlet() + }; + string warning = "This is a warning!"; logger.WriteWarning(warning); From 56bfb4cd20d8e18a0ff228d8ce004583da549232 Mon Sep 17 00:00:00 2001 From: Abhishek Chikkam Date: Sat, 5 Jul 2025 14:49:32 -0700 Subject: [PATCH 3/7] onbaording Unit tests to powerbIlogger --- src/Common/Commands.Common.Test/PowerBILoggerTests.cs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index 81338cb8..8e166f1e 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -30,6 +30,17 @@ public void TestDetectingIsPowerBICmdlet() Assert.IsNull(logger.GetPowerBICmdlet); } + + [TestMethod] + public void TestWriteWarningAddsMessage() + { + var logger = new PowerBILoggerMock(); + string warning = "This is a warning!"; + logger.WriteWarning(warning); + + Assert.AreEqual(1, logger.WarningMessages.Count); + Assert.AreEqual(warning, logger.WarningMessages[0]); + } [TestMethod] public void TestMainThreadDetection() From 798d5023f0be94a3515aa3132b46f026d4006997 Mon Sep 17 00:00:00 2001 From: Abhishek Chikkam Date: Tue, 8 Jul 2025 11:17:23 -0700 Subject: [PATCH 4/7] modified logic --- src/Common/Commands.Common.Test/PowerBILoggerTests.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index 8e166f1e..2d78ee7a 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -34,7 +34,11 @@ public void TestDetectingIsPowerBICmdlet() [TestMethod] public void TestWriteWarningAddsMessage() { - var logger = new PowerBILoggerMock(); + var logger = new PowerBILoggerMock() + { + Cmdlet = new NonPowerBICmdlet() + }; + string warning = "This is a warning!"; logger.WriteWarning(warning); From 23d35d7f4f3496f03200e6a97c4c90c759614d86 Mon Sep 17 00:00:00 2001 From: Beabhi17 <134540249+Beabhi17@users.noreply.github.com> Date: Fri, 4 Jul 2025 02:24:44 -0700 Subject: [PATCH 5/7] Update PowerBILoggerTests.cs --- .../Commands.Common.Test/PowerBILoggerTests.cs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index 2d78ee7a..afdd3a13 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -46,6 +46,17 @@ public void TestWriteWarningAddsMessage() Assert.AreEqual(warning, logger.WarningMessages[0]); } + [TestMethod] + public void TestWriteWarningAddsMessage() + { + var logger = new PowerBILoggerMock(); + string warning = "This is a warning!"; + logger.WriteWarning(warning); + + Assert.AreEqual(1, logger.WarningMessages.Count); + Assert.AreEqual(warning, logger.WarningMessages[0]); + } + [TestMethod] public void TestMainThreadDetection() { @@ -120,4 +131,4 @@ public override void ExecuteCmdlet() // Nothing } } -} \ No newline at end of file +} From 08c89dcd21160f82638c24170b18d47eca9e42db Mon Sep 17 00:00:00 2001 From: Beabhi17 <134540249+Beabhi17@users.noreply.github.com> Date: Sat, 5 Jul 2025 14:07:37 -0700 Subject: [PATCH 6/7] Update PowerBILoggerTests.cs --- src/Common/Commands.Common.Test/PowerBILoggerTests.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index afdd3a13..0af574d2 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -49,7 +49,11 @@ public void TestWriteWarningAddsMessage() [TestMethod] public void TestWriteWarningAddsMessage() { - var logger = new PowerBILoggerMock(); + var logger = new PowerBILoggerMock() + { + Cmdlet = new NonPowerBICmdlet() + }; + string warning = "This is a warning!"; logger.WriteWarning(warning); From 000df76b59914e3b18bd9dc49beb2d0a5b15780c Mon Sep 17 00:00:00 2001 From: Abhishek Chikkam Date: Tue, 8 Jul 2025 11:25:33 -0700 Subject: [PATCH 7/7] removed duplicate code --- .../Commands.Common.Test/PowerBILoggerTests.cs | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs index 0af574d2..56d4034e 100644 --- a/src/Common/Commands.Common.Test/PowerBILoggerTests.cs +++ b/src/Common/Commands.Common.Test/PowerBILoggerTests.cs @@ -30,21 +30,7 @@ public void TestDetectingIsPowerBICmdlet() Assert.IsNull(logger.GetPowerBICmdlet); } - - [TestMethod] - public void TestWriteWarningAddsMessage() - { - var logger = new PowerBILoggerMock() - { - Cmdlet = new NonPowerBICmdlet() - }; - string warning = "This is a warning!"; - logger.WriteWarning(warning); - - Assert.AreEqual(1, logger.WarningMessages.Count); - Assert.AreEqual(warning, logger.WarningMessages[0]); - } [TestMethod] public void TestWriteWarningAddsMessage()