From 014fae8c13f89db32ce059bc164f592f9025ad14 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Mon, 19 Jan 2026 09:49:50 -0500 Subject: [PATCH 1/2] fix: null reference exception on model import if the member schema cannot be resolved Signed-off-by: Vincent Biret --- .../src/cli/actions/convert/generators/generate-model.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/openapi3/src/cli/actions/convert/generators/generate-model.ts b/packages/openapi3/src/cli/actions/convert/generators/generate-model.ts index c30f4c11f40..f73040d194b 100644 --- a/packages/openapi3/src/cli/actions/convert/generators/generate-model.ts +++ b/packages/openapi3/src/cli/actions/convert/generators/generate-model.ts @@ -245,10 +245,12 @@ function generateUnion(union: TypeSpecUnion, context: Context): string { return ""; } - const memberSchema = "$ref" in member ? context.getSchemaByRef(member.$ref)! : member; + const memberSchema = "$ref" in member ? context.getSchemaByRef(member.$ref) : member; const propertySchema = - memberSchema.properties && memberSchema.properties[union.schema.discriminator.propertyName]; + memberSchema && + memberSchema.properties && + memberSchema.properties[union.schema.discriminator.propertyName]; const value = (union.schema.discriminator?.mapping && "$ref" in member ? Object.entries(union.schema.discriminator.mapping).find((x) => x[1] === member.$ref)?.[0] From fdb0fe0c04e507af3c1a3a89d3fdc3f755cfc913 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Mon, 19 Jan 2026 09:51:42 -0500 Subject: [PATCH 2/2] docs: adds chronus entry for null reference exception --- .../changes/fix-NRE-generate-model-2026-0-19-9-51-29.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .chronus/changes/fix-NRE-generate-model-2026-0-19-9-51-29.md diff --git a/.chronus/changes/fix-NRE-generate-model-2026-0-19-9-51-29.md b/.chronus/changes/fix-NRE-generate-model-2026-0-19-9-51-29.md new file mode 100644 index 00000000000..6def08dc384 --- /dev/null +++ b/.chronus/changes/fix-NRE-generate-model-2026-0-19-9-51-29.md @@ -0,0 +1,7 @@ +--- +changeKind: fix +packages: + - "@typespec/openapi3" +--- + +importer - null reference exception if member schema cannot be resolved \ No newline at end of file