From 1b965ac3b5b78bc5572cb0c8f16694253cb9c455 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Mon, 28 Mar 2022 16:04:32 -0700 Subject: [PATCH 01/21] Added arm64 architecture for wider support --- azure-pipelines/build-openconsole.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/azure-pipelines/build-openconsole.yml b/azure-pipelines/build-openconsole.yml index 62c9126..8318166 100644 --- a/azure-pipelines/build-openconsole.yml +++ b/azure-pipelines/build-openconsole.yml @@ -1,6 +1,6 @@ steps: - task: VSBuild@1 - displayName: 'Build OpenConsole' + displayName: 'Build OpenConsole x86' inputs: solution: 'dep/terminal/OpenConsole.sln' msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE @@ -8,9 +8,17 @@ steps: configuration: '$(BuildConfiguration)' - task: VSBuild@1 - displayName: 'Build OpenConsole' + displayName: 'Build OpenConsole x64' inputs: solution: 'dep/terminal/OpenConsole.sln' msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE platform: 'x64' + configuration: '$(BuildConfiguration)' + +- task: VSBuild@1 + displayName: 'Build OpenConsole ' + inputs: + solution: 'dep/terminal/OpenConsole.sln' + msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE + platform: 'Arm64' configuration: '$(BuildConfiguration)' \ No newline at end of file From b0574dfe3ba99b70f57091bc78bea535f9868e14 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Mon, 28 Mar 2022 16:10:10 -0700 Subject: [PATCH 02/21] Added support for arm64 Conhost and OpenConsole --- src/Pty.Net/Pty.Net.csproj | 12 ++++++ src/Pty.Net/Windows/NativeMethods.cs | 59 ++++++++++++++++++---------- 2 files changed, 50 insertions(+), 21 deletions(-) diff --git a/src/Pty.Net/Pty.Net.csproj b/src/Pty.Net/Pty.Net.csproj index 6e4634e..8f00381 100644 --- a/src/Pty.Net/Pty.Net.csproj +++ b/src/Pty.Net/Pty.Net.csproj @@ -37,6 +37,7 @@ build\ + true build\x86\os86 @@ -54,6 +55,7 @@ build\x86\os64 + true build\x64\os86 @@ -70,6 +72,16 @@ true build\x64\os64 + + + + true + build\x64\arm64 + + + true + build\x64\arm64 + diff --git a/src/Pty.Net/Windows/NativeMethods.cs b/src/Pty.Net/Windows/NativeMethods.cs index f6109eb..d920991 100644 --- a/src/Pty.Net/Windows/NativeMethods.cs +++ b/src/Pty.Net/Windows/NativeMethods.cs @@ -78,37 +78,43 @@ internal static extern bool CreateProcess( internal static int CreatePseudoConsole(Coord coord, IntPtr input, IntPtr output, uint flags, out IntPtr consoleHandle) { - if (Environment.Is64BitOperatingSystem) - { - return CreatePseudoConsole64(coord, input, output, flags, out consoleHandle); - } - else - { - return CreatePseudoConsole86(coord, input, output, flags, out consoleHandle); + switch (RuntimeInformation.ProcessArchitecture) + { + case Architecture.Arm64: + return CreatePseudoConsoleArm64(coord, input, output, flags, out consoleHandle); + case Architecture.X64: + return CreatePseudoConsole64(coord, input, output, flags, out consoleHandle); + default: + return CreatePseudoConsole86(coord, input, output, flags, out consoleHandle); } } internal static int ResizePseudoConsole(SafePseudoConsoleHandle consoleHandle, Coord coord) { - if (Environment.Is64BitOperatingSystem) - { - return ResizePseudoConsole64(consoleHandle, coord); - } - else - { - return ResizePseudoConsole86(consoleHandle, coord); + switch (RuntimeInformation.ProcessArchitecture) + { + case Architecture.Arm64: + return ResizePseudoConsoleArm64(consoleHandle, coord); + case Architecture.X64: + return ResizePseudoConsole64(consoleHandle, coord); + default: + return ResizePseudoConsole86(consoleHandle, coord); } } internal static void ClosePseudoConsole(IntPtr consoleHandle) { - if (Environment.Is64BitOperatingSystem) - { - ClosePseudoConsole64(consoleHandle); - } - else - { - ClosePseudoConsole86(consoleHandle); + switch (RuntimeInformation.ProcessArchitecture) + { + case Architecture.Arm64: + ClosePseudoConsoleArm64(consoleHandle); + break; + case Architecture.X64: + ClosePseudoConsole64(consoleHandle); + break; + default: + ClosePseudoConsole86(consoleHandle); + break; } } @@ -127,6 +133,17 @@ internal static extern bool CreatePipe( [DllImport("kernel32.dll")] internal static extern IntPtr GetProcAddress(IntPtr hModule, [MarshalAs(UnmanagedType.LPStr)] string procName); + [DllImport("arm64\\conpty.dll", EntryPoint = "CreatePseudoConsole")] + [ReliabilityContract(Consistency.WillNotCorruptState, Cer.MayFail)] + private static extern int CreatePseudoConsoleArm64(Coord coord, IntPtr input, IntPtr output, uint flags, out IntPtr consoleHandle); + + [DllImport("arm64\\conpty.dll", EntryPoint = "ResizePseudoConsole")] + private static extern int ResizePseudoConsoleArm64(SafePseudoConsoleHandle consoleHandle, Coord coord); + + [DllImport("arm64\\conpty.dll", EntryPoint = "ClosePseudoConsole")] + [ReliabilityContract(Consistency.WillNotCorruptState, Cer.Success)] + private static extern void ClosePseudoConsoleArm64(IntPtr consoleHandle); + [DllImport("os64\\conpty.dll", EntryPoint = "CreatePseudoConsole")] [ReliabilityContract(Consistency.WillNotCorruptState, Cer.MayFail)] private static extern int CreatePseudoConsole64(Coord coord, IntPtr input, IntPtr output, uint flags, out IntPtr consoleHandle); From f33cb84a0e816697b26aeb8662d56c4e375ffca5 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Tue, 29 Mar 2022 10:45:27 -0700 Subject: [PATCH 03/21] removed x86 versions of ConHost and WinPty --- azure-pipelines/build-openconsole.yml | 11 +---------- azure-pipelines/build-winpty.yml | 3 --- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/azure-pipelines/build-openconsole.yml b/azure-pipelines/build-openconsole.yml index 8318166..fde04f7 100644 --- a/azure-pipelines/build-openconsole.yml +++ b/azure-pipelines/build-openconsole.yml @@ -1,12 +1,3 @@ -steps: -- task: VSBuild@1 - displayName: 'Build OpenConsole x86' - inputs: - solution: 'dep/terminal/OpenConsole.sln' - msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE - platform: 'x86' - configuration: '$(BuildConfiguration)' - - task: VSBuild@1 displayName: 'Build OpenConsole x64' inputs: @@ -16,7 +7,7 @@ steps: configuration: '$(BuildConfiguration)' - task: VSBuild@1 - displayName: 'Build OpenConsole ' + displayName: 'Build OpenConsole Arm64' inputs: solution: 'dep/terminal/OpenConsole.sln' msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE diff --git a/azure-pipelines/build-winpty.yml b/azure-pipelines/build-winpty.yml index d90e30b..21b8996 100644 --- a/azure-pipelines/build-winpty.yml +++ b/azure-pipelines/build-winpty.yml @@ -10,8 +10,5 @@ steps: - script: echo $PATH displayName: Print PATH -- script: dep/winpty/vcbuild.bat --msvc-platform Win32 --toolset v142 --gyp-msvs-version 2017 - displayName: Build x86 winpty - - script: dep/winpty/vcbuild.bat --msvc-platform x64 --toolset v142 --gyp-msvs-version 2017 displayName: Build x64 winpty From beb92d0ca5d87409ac239d2cb93e1662d3d07b30 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Tue, 29 Mar 2022 10:46:23 -0700 Subject: [PATCH 04/21] Fixed yaml --- azure-pipelines/build-openconsole.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/azure-pipelines/build-openconsole.yml b/azure-pipelines/build-openconsole.yml index fde04f7..ffe667e 100644 --- a/azure-pipelines/build-openconsole.yml +++ b/azure-pipelines/build-openconsole.yml @@ -1,3 +1,4 @@ +steps: - task: VSBuild@1 displayName: 'Build OpenConsole x64' inputs: @@ -11,5 +12,5 @@ inputs: solution: 'dep/terminal/OpenConsole.sln' msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE - platform: 'Arm64' + platform: 'rm64' configuration: '$(BuildConfiguration)' \ No newline at end of file From 165e8b1cae25b96214bb2fb6e9a2b2ca6012c0ed Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 09:27:18 -0700 Subject: [PATCH 05/21] Using python 3.6.8 --- azure-pipelines/build-winpty.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/azure-pipelines/build-winpty.yml b/azure-pipelines/build-winpty.yml index 21b8996..ead7421 100644 --- a/azure-pipelines/build-winpty.yml +++ b/azure-pipelines/build-winpty.yml @@ -1,9 +1,9 @@ steps: -# - task: UsePythonVersion@0 -# inputs: -# versionSpec: 3.6 -# addToPath: true -# architecture: x64 +- task: UsePythonVersion@0 + inputs: + versionSpec: 3.6.8 + addToPath: true + architecture: x64 - powershell: azure-pipelines/Set-MSBuildPath.ps1 From fa58f95bfb58bc33aedd14fd0c07e1ae6fddc2d9 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 09:33:40 -0700 Subject: [PATCH 06/21] Bumping python to 3.9 --- azure-pipelines/build-winpty.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/build-winpty.yml b/azure-pipelines/build-winpty.yml index ead7421..76f90a0 100644 --- a/azure-pipelines/build-winpty.yml +++ b/azure-pipelines/build-winpty.yml @@ -1,7 +1,7 @@ steps: - task: UsePythonVersion@0 inputs: - versionSpec: 3.6.8 + versionSpec: 3.9 addToPath: true architecture: x64 From 0a28f27c12a2e67f616e18dca05080de9b941c9e Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 09:54:15 -0700 Subject: [PATCH 07/21] Skipping WinPty build for now --- azure-pipelines/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/build.yml b/azure-pipelines/build.yml index 373f18c..a887ee2 100644 --- a/azure-pipelines/build.yml +++ b/azure-pipelines/build.yml @@ -9,7 +9,7 @@ jobs: - script: .\nbgv cloud -p src - ${{ if eq(variables['system.collectionId'], '011b8bdf-6d56-4f87-be0d-0092136884d9') }}: - template: microbuild.before.yml - - template: build-winpty.yml +# - template: build-winpty.yml - template: build-openconsole.yml - template: msbuild.yml - template: publish.yml From 302a022325eeaa1734ee4ff473048f8ec4edb5af Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 10:03:51 -0700 Subject: [PATCH 08/21] Fixed typo --- azure-pipelines/build-openconsole.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/build-openconsole.yml b/azure-pipelines/build-openconsole.yml index ffe667e..b10be65 100644 --- a/azure-pipelines/build-openconsole.yml +++ b/azure-pipelines/build-openconsole.yml @@ -12,5 +12,5 @@ steps: inputs: solution: 'dep/terminal/OpenConsole.sln' msbuildArgs: /t:Conhost\winconpty_DLL;Conhost\Host_EXE - platform: 'rm64' + platform: 'Arm64' configuration: '$(BuildConfiguration)' \ No newline at end of file From 0ab60d67d20c395353c707ebc0806763188a6655 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 10:20:36 -0700 Subject: [PATCH 09/21] removed winPty references from Pty.Net projects --- src/OSS.Sign/OSS.Sign.csproj | 10 +++++----- src/Pty.Net/Pty.Net.csproj | 12 +++++++++--- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/OSS.Sign/OSS.Sign.csproj b/src/OSS.Sign/OSS.Sign.csproj index 6aa2cee..34cf06c 100644 --- a/src/OSS.Sign/OSS.Sign.csproj +++ b/src/OSS.Sign/OSS.Sign.csproj @@ -24,7 +24,7 @@ x64 - + + @@ -58,10 +58,10 @@ - + - + \ No newline at end of file diff --git a/src/Pty.Net/Pty.Net.csproj b/src/Pty.Net/Pty.Net.csproj index 8f00381..768a1d1 100644 --- a/src/Pty.Net/Pty.Net.csproj +++ b/src/Pty.Net/Pty.Net.csproj @@ -5,10 +5,10 @@ - + false @@ -16,6 +16,12 @@ os64\ + + false + PreserveNewest + arm64\ + + true build\ @@ -30,7 +36,7 @@ - + true From 5e0211a6dbd086ce5eb974a42d18f0d8230c80f2 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 10:39:47 -0700 Subject: [PATCH 10/21] Fixed paths --- src/OSS.Sign/OSS.Sign.csproj | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/OSS.Sign/OSS.Sign.csproj b/src/OSS.Sign/OSS.Sign.csproj index 34cf06c..d1c4d97 100644 --- a/src/OSS.Sign/OSS.Sign.csproj +++ b/src/OSS.Sign/OSS.Sign.csproj @@ -11,16 +11,22 @@ - + + + x64 + + + x64 - + x64 - + x64 From 7501cd04f41fb750c2f87ea7e51ac4b6445aff34 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 10:50:34 -0700 Subject: [PATCH 11/21] Removed more x86 entries --- src/Pty.Net/Pty.Net.csproj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Pty.Net/Pty.Net.csproj b/src/Pty.Net/Pty.Net.csproj index 768a1d1..225c3bd 100644 --- a/src/Pty.Net/Pty.Net.csproj +++ b/src/Pty.Net/Pty.Net.csproj @@ -44,7 +44,7 @@ - + @@ -70,10 +70,10 @@ true build\x64\os64 - + true build\x64\os64 From 1adbcae343d94e1bf95ba10feac9fa1c39d58168 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 1 Apr 2022 11:22:56 -0700 Subject: [PATCH 12/21] Fixed package path for OSS project --- src/OSS.Sign/OSS.Sign.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OSS.Sign/OSS.Sign.csproj b/src/OSS.Sign/OSS.Sign.csproj index d1c4d97..18a5417 100644 --- a/src/OSS.Sign/OSS.Sign.csproj +++ b/src/OSS.Sign/OSS.Sign.csproj @@ -24,10 +24,10 @@ x64 - x64 + Arm64 - x64 + Arm64 + x64 diff --git a/src/Pty.Net/Pty.Net.csproj b/src/Pty.Net/Pty.Net.csproj index 225c3bd..768a1d1 100644 --- a/src/Pty.Net/Pty.Net.csproj +++ b/src/Pty.Net/Pty.Net.csproj @@ -44,7 +44,7 @@ - + @@ -70,10 +70,10 @@ true build\x64\os64 - + true build\x64\os64 From 228c4518a3a45c6e276365a32c64518f74d6b5dc Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Mon, 4 Apr 2022 11:40:48 -0500 Subject: [PATCH 14/21] Bumped azure devOps wrapup stage to newer ubuntu version --- azure-pipelines/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/build.yml b/azure-pipelines/build.yml index a887ee2..28c1dc3 100644 --- a/azure-pipelines/build.yml +++ b/azure-pipelines/build.yml @@ -45,7 +45,7 @@ jobs: - Linux - MacOS pool: - vmImage: Ubuntu 16.04 + vmImage: Ubuntu 18.04 condition: succeededOrFailed() steps: - checkout: self From b3240f03181f55806ccad80c28892630003614a1 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Tue, 5 Apr 2022 10:27:10 -0700 Subject: [PATCH 15/21] Cleaned up file placements --- src/Pty.Net/Pty.Net.csproj | 14 ++++++++++---- src/Pty.Net/Pty.Net.targets | 13 +++++++++++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/src/Pty.Net/Pty.Net.csproj b/src/Pty.Net/Pty.Net.csproj index 768a1d1..a626aae 100644 --- a/src/Pty.Net/Pty.Net.csproj +++ b/src/Pty.Net/Pty.Net.csproj @@ -10,6 +10,12 @@ PreserveNewest --> + + false + PreserveNewest + os86\ + + false PreserveNewest @@ -38,10 +44,10 @@ - + @@ -82,11 +88,11 @@ true - build\x64\arm64 + build\arm64 true - build\x64\arm64 + build\arm64 diff --git a/src/Pty.Net/Pty.Net.targets b/src/Pty.Net/Pty.Net.targets index b18a96e..f36b698 100644 --- a/src/Pty.Net/Pty.Net.targets +++ b/src/Pty.Net/Pty.Net.targets @@ -1,7 +1,16 @@  - + + + + + + + + + + + From 9413e66c4f070ef7c8924148b16c42b8121111be Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Tue, 5 Apr 2022 11:11:47 -0700 Subject: [PATCH 16/21] Cleanup and QOL changes --- src/OSS.Sign/OSS.Sign.csproj | 34 ++++++++++++++++++++++++++++------ src/Pty.Net/Pty.Net.targets | 10 +++++----- 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/src/OSS.Sign/OSS.Sign.csproj b/src/OSS.Sign/OSS.Sign.csproj index ed01403..0a65bea 100644 --- a/src/OSS.Sign/OSS.Sign.csproj +++ b/src/OSS.Sign/OSS.Sign.csproj @@ -11,22 +11,44 @@ - + + x86 - + x86 - + x64 - + x64 - + Arm64 - + + Arm64 + + + + + + x86 + + + x86 + + + x64 + + + x64 + + + Arm64 + + Arm64 diff --git a/src/Pty.Net/Pty.Net.targets b/src/Pty.Net/Pty.Net.targets index f36b698..507df81 100644 --- a/src/Pty.Net/Pty.Net.targets +++ b/src/Pty.Net/Pty.Net.targets @@ -1,15 +1,15 @@  - - + + - - + + - + From 58a497b64ccab012037a1ac55323b83585a24e9e Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Wed, 6 Apr 2022 16:27:29 -0700 Subject: [PATCH 17/21] Fixed arm64 path for CopyPtyNativeFiles --- src/Pty.Net/Pty.Net.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Pty.Net/Pty.Net.targets b/src/Pty.Net/Pty.Net.targets index 507df81..094cf6e 100644 --- a/src/Pty.Net/Pty.Net.targets +++ b/src/Pty.Net/Pty.Net.targets @@ -9,7 +9,7 @@ - + From cee52c4e6df3cb18c693ade82a896dbb36f1592d Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Thu, 7 Apr 2022 17:16:52 -0700 Subject: [PATCH 18/21] fixed Pty.Net.targets --- src/Pty.Net/Pty.Net.targets | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/Pty.Net/Pty.Net.targets b/src/Pty.Net/Pty.Net.targets index 094cf6e..6aa8232 100644 --- a/src/Pty.Net/Pty.Net.targets +++ b/src/Pty.Net/Pty.Net.targets @@ -1,16 +1,11 @@  - - - - - - - - - - - + + + From 66e6f262df7fe1b53a6e66dad67fb15d78aa011c Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 15 Apr 2022 09:52:08 -0700 Subject: [PATCH 19/21] Adding WinPty to build process --- azure-pipelines/build-winpty.yml | 8 +------- azure-pipelines/build.yml | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/azure-pipelines/build-winpty.yml b/azure-pipelines/build-winpty.yml index 76f90a0..f703cdd 100644 --- a/azure-pipelines/build-winpty.yml +++ b/azure-pipelines/build-winpty.yml @@ -1,14 +1,8 @@ steps: -- task: UsePythonVersion@0 - inputs: - versionSpec: 3.9 - addToPath: true - architecture: x64 - - powershell: azure-pipelines/Set-MSBuildPath.ps1 - script: echo $PATH displayName: Print PATH - script: dep/winpty/vcbuild.bat --msvc-platform x64 --toolset v142 --gyp-msvs-version 2017 - displayName: Build x64 winpty + displayName: Build x64 WinPty diff --git a/azure-pipelines/build.yml b/azure-pipelines/build.yml index 28c1dc3..7c0f2d7 100644 --- a/azure-pipelines/build.yml +++ b/azure-pipelines/build.yml @@ -9,7 +9,7 @@ jobs: - script: .\nbgv cloud -p src - ${{ if eq(variables['system.collectionId'], '011b8bdf-6d56-4f87-be0d-0092136884d9') }}: - template: microbuild.before.yml -# - template: build-winpty.yml + - template: build-winpty.yml - template: build-openconsole.yml - template: msbuild.yml - template: publish.yml From 3bd7a7e33439d8d3f8473a4bbae1684f25ab93e8 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 15 Apr 2022 10:13:50 -0700 Subject: [PATCH 20/21] Downgrading to VS 2017 build pool --- azure-pipelines/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/build.yml b/azure-pipelines/build.yml index 7c0f2d7..1bf8a6a 100644 --- a/azure-pipelines/build.yml +++ b/azure-pipelines/build.yml @@ -1,6 +1,6 @@ jobs: - job: Windows - pool: VSEngSS-MicroBuild2019-1ES + pool: VSEngSS-MicroBuild2017-1ES steps: - checkout: self submodules: recursive From 32aa66d55110f58740c8a77a38f53ab71f00dbf6 Mon Sep 17 00:00:00 2001 From: Javier De la Garza Sanchez Date: Fri, 15 Apr 2022 10:22:23 -0700 Subject: [PATCH 21/21] Revert "Downgrading to VS 2017 build pool" This reverts commit 3bd7a7e33439d8d3f8473a4bbae1684f25ab93e8. --- azure-pipelines/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines/build.yml b/azure-pipelines/build.yml index 1bf8a6a..7c0f2d7 100644 --- a/azure-pipelines/build.yml +++ b/azure-pipelines/build.yml @@ -1,6 +1,6 @@ jobs: - job: Windows - pool: VSEngSS-MicroBuild2017-1ES + pool: VSEngSS-MicroBuild2019-1ES steps: - checkout: self submodules: recursive