Skip to content

Improvements to mappings and automate manual steps #196

@hbons

Description

@hbons

Right now adding/changing icons in VS Code feels like it needs too many manual steps.

Issues:

  • icons.ttf causes unresolvable conflicts and blocks having multiple PRs open in progress. It should probably not be kept in the git repo being a binary file.
  • Can't easily see what icons share a mapping in mapping.json
  • Need to manually add an arbitrary number to mapping.json` and its hex value to codicons.ts which is error prone
  • icons.ttf needs to be manually committed to the main vscode repo

Possible improvements:

  • Add CI to check for errors
  • When a PR is merged or a commit made, CI can publish dist/icons.* to the Releases page. This way we keep the repo free of conflicts and can have multiple ongoing PRs open at the same time
  • Add icons.ttf to the gitignore so it doesn't get committed.
  • Use JSON lists to group names in mapping.json. This way we can see which icon names map to the same icon, and we don't need to add numbers. This will also make the mappings much easier to edit.
  • Remove the manual numbering in the mapping.json. This can be autogenerated when the previous suggestion is implemented.
  • Automatically create a PR to the vscode repo with the new icons.ttf
  • Automatically update vscode-docs

MAGIC LEVEL:

  • Launch a web instance for each with the new icons for review.

We can ask Lee to help us with this.
cc @daviddossett

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions