Problem text fix request

[josundt]

For a long time we have used the vscode-eslint extension alongside a custom vscode task (configured in our project's .vscode/tasks.json).

The custom task executes the eslint CLI with the stylish output formatter and then use vscode's built-in $eslint-stylish problemMatcher to parse CLI output and display the findings in the problems panel.

The extension and the custom task has supplemented each other in a very useful way. While the vscode-eslint extension provide real-time reporting for open editors, the vscode tasks reports findings across all scanned files.

These two functions also played very nicely together. Even if the same problem was reported by both the extension and the custom task for open files, the problems were merged by vscode, and no duplicates appeared in the problems panel, since the text content from the two sources was identical. And after fixing an issue in an open editor (manually or using auto-fixer), the problem in the panel disappeared nicely.

But then - after an update of the vscode-eslint extension some months ago, a period (.) character was added to the problem text from the vscode extension. After that; since the text content now is slightly different (1 character!), errors are not merged the same way, and duplicates appear in the problems panel. And after fixing an error in an open editor, only the error that originated from the extension disappears from the problems panel. (Please see image below).

I have been thinking about reporting this for some time now, but never got around to it.

But at this point it has bugged me long enough for me to kindly ask if you could please remove this period (.) character from the problem message again. I hope I have been able to prove the benefits of keeping the extension's problem message identical to the output from eslint itselft.

[dbaeumer]

Actually, VS Code doesn't dedupe problem based on their message. So the problem very likely has a different source. Can you provide me wit a GitHub repository I can clone with a minimal setup that demos what you are seeing.

[josundt]

I made a repo to reproduce the issue here.

• There is a script "lint" defined in package.json, which simply runs eslint src.
• There is a vscode task defined in tasks.json that executes the npm script, and uses the $eslint-stylish built-in problemMatcher.
  (FYI: This task is defined as default build task, so it can be started using keyboard shortcut CTRL/CMD + SHIFT + B) .
• If you execute the task and also open src/index.js in the editor, you should see duplicate issues, one reported by the task and the other reported by the extension.

Earlier the problems from the two sources were merged into one, either deliberately or coincidentally.
That seemed to happen since the plain text content for the problems from both sources was identical (even if the problem from the extension includes a hyperlink).

At some point duplicates started appearing, and I noticed that the plain text content of the problems from the extension suddenly had a period character added that I don't think was there before.

I therefore strongly suspect that the formerly so convenient "duplicate merging behavior" would start working again if the period character was removed from the problem text from the extension.