Run tests on class does not take inherited methods into consideration

[maxandersen]

When you have a test class with inherited test methods only the methods explicitly marked on the current class gets run. Would have expected it to run all tests.

Example:
https://github.com/jbake-org/jbake/blob/master/jbake-core/src/test/java/org/jbake/app/template/FreemarkerTemplateEngineRenderingTest.java#L40

If you run this only 2 tests are run, none of the @test from its super class (https://github.com/jbake-org/jbake/blob/master/jbake-core/src/test/java/org/jbake/app/template/AbstractTemplateEngineRenderingTest.java) are run

[joshmanderson]

I might also add that along with tests inherited from a parent class, it would be useful to also be able to run tests from default interface methods. Note: I'm pretty sure this requires running the tests using junit 5+ (if using junit).

E.g. Given:

public interface CanJumpTest<TestInstance extends CanJump> {
    TestInstance getTestInstance();

    int getMinExpectedJumpHeight();

    @Test
    default void canJumpToExpectedHeight()  {
        assertThat(getTestInstance().jump()).isGreaterThanOrEqualTo(getMinExpectedJumpHeight());
    }
}

public class BasketballPlayerTest implements CanJumpTest<BasketballPlayer> {
    @Override
    BasketballPlayer getTestInstance() {
        return new BasketballPlayer();
    }

    @Override
    int getMinExpectedJumpHeight() {
        return 70;
    }
}

Running BasketballPlayerTest should run the canJumpToExpectedHeight test.

[jdneo]

This issue will be addressed in 0.15.0

We refactored the logic of parsing the test results recently.

[lanfuchao]

Is this issue fixed? encounter the same issue in 0.19.0.

[Sunnyxpected]

is there an update to this? I'm currently working around it by just dragging the inherited methods into the classes, which is quite messy

[jdneo]

@Sunnyxpected We have limited support for this scenario, but if you trigger the tests at the inherited class, the methods from the super class should also get run and appear in the test report. Could you provide more information about the problem you have?

[Sunnyxpected]

i have lets say a LoginAbstract class, which contains the Test Method.
then i have a class called LoginFooTest which inherits said abstract class, but overrides an abstract method called getUser.
if i then run the tester on the class, my expected result (from past working with eclipse) is that the test runner runs the inherited methods, however he doesnt

My current workaround is to just copy in all the test methods from the parent

[jdneo]

@Sunnyxpected Seems some words are missing in the comments.

Do you mean you want to run the methods in the super type and hope to get the results for all the inherited ones?

[Sunnyxpected]

yes there is test methods in the super type that i want to run in the subtype which inherits those.