From d02f700b1814d7921b2a4c89fa89aa7a817e087c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 9 Dec 2025 21:37:45 +0000 Subject: [PATCH 1/2] Initial plan From d0cccb45271dec857fdd19a333a38f85c32f38f2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 9 Dec 2025 21:46:15 +0000 Subject: [PATCH 2/2] Add modal dialog support for invalid interpreter errors - Modified DiagnosticCommandPromptHandlerService to display error severity diagnostics as modal dialogs - Updated all related unit tests to expect modal option for error messages - This makes invalid interpreter errors more prominent and blocking as requested Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com> --- src/client/application/diagnostics/promptHandler.ts | 2 +- .../application/diagnostics/promptHandler.unit.test.ts | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/client/application/diagnostics/promptHandler.ts b/src/client/application/diagnostics/promptHandler.ts index 25b946b2ffb5..047c4797fc60 100644 --- a/src/client/application/diagnostics/promptHandler.ts +++ b/src/client/application/diagnostics/promptHandler.ts @@ -54,7 +54,7 @@ export class DiagnosticCommandPromptHandlerService implements IDiagnosticHandler ): Promise { switch (severity) { case DiagnosticSeverity.Error: { - return this.appShell.showErrorMessage(message, ...prompts); + return this.appShell.showErrorMessage(message, { modal: true }, ...prompts); } case DiagnosticSeverity.Warning: { return this.appShell.showWarningMessage(message, ...prompts); diff --git a/src/test/application/diagnostics/promptHandler.unit.test.ts b/src/test/application/diagnostics/promptHandler.unit.test.ts index 0c8d732b15f4..165527394a3b 100644 --- a/src/test/application/diagnostics/promptHandler.unit.test.ts +++ b/src/test/application/diagnostics/promptHandler.unit.test.ts @@ -47,7 +47,12 @@ suite('Application Diagnostics - PromptHandler', () => { switch (severity.value) { case DiagnosticSeverity.Error: { appShell - .setup((a) => a.showErrorMessage(typemoq.It.isValue(diagnostic.message))) + .setup((a) => + a.showErrorMessage( + typemoq.It.isValue(diagnostic.message), + typemoq.It.isValue({ modal: true }), + ), + ) .verifiable(typemoq.Times.once()); break; } @@ -92,6 +97,7 @@ suite('Application Diagnostics - PromptHandler', () => { .setup((a) => a.showErrorMessage( typemoq.It.isValue(options.message!), + typemoq.It.isValue({ modal: true }), typemoq.It.isValue('Yes'), typemoq.It.isValue('No'), ), @@ -152,6 +158,7 @@ suite('Application Diagnostics - PromptHandler', () => { .setup((a) => a.showErrorMessage( typemoq.It.isValue(options.message!), + typemoq.It.isValue({ modal: true }), typemoq.It.isValue('Yes'), typemoq.It.isValue('No'), ), @@ -213,6 +220,7 @@ suite('Application Diagnostics - PromptHandler', () => { .setup((a) => a.showErrorMessage( typemoq.It.isValue(options.message!), + typemoq.It.isValue({ modal: true }), typemoq.It.isValue('Yes'), typemoq.It.isValue('No'), ),