Skip to content

feat: use NODE_KEY_FILE for better security #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilescope wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: use NODE_KEY_FILE for better security #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f329cc
feat: use NODE_KEY_FILE for better security
gilescope Jun 16, 2025
6e826d0
Merge branch 'main' into giles-node-key-file
gilescope Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ if [ ! -f node.privatekey ]; then
DOCKER_DEFAULT_PLATFORM=linux/amd64 docker run --rm -it docker.io/parity/subkey:latest generate-node-key | sed -n '2p' > midnight-node.privatekey
# Use the second line of output for NODE_KEY (that's what sed -n '2p' does)
fi
export NODE_KEY="$(cat ./midnight-node.privatekey)"
export NODE_KEY_FILE="./midnight-node.privatekey"

#
# Partner chains config:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## 🚀 Features

- Recommended to use NODE_KEY_FILE rather than NODE_KEY
- Cardano's ipc socket file is now stored in a docker volume so when stale can be recreated on all OSes.
- `cardano-cli.sh`, `midnight-node.sh` and `midnight-shell.sh` execute within the running container.
- Switch networks by altering CFG_PRESET only
Expand Down
3 changes: 2 additions & 1 deletion compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@
- BOOTNODES=${BOOTNODES}
- CFG_PRESET=${CFG_PRESET}
- DB_SYNC_POSTGRES_CONNECTION_STRING=${DB_SYNC_POSTGRES_CONNECTION_STRING}
- NODE_KEY=${NODE_KEY}
- NODE_KEY_FILE=/midnight-node.privatekey
healthcheck:
test: [ "CMD", "curl", "-f", "http://localhost:9944/health" ]
interval: 2s
volumes:
- ./data:/data
- ./envs/${CFG_PRESET}/pc-chain-config.json:/pc-chain-config.json
- midnight-data-testnet:/node
- ${NODE_KEY_FILE}:/midnight-node.privatekey:ro