Skip to content

Idea for the design of the WIndow to submit to save reversions from fast blocks. #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monkins1010 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Idea for the design of the WIndow to submit to save reversions from fast blocks. #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/pbaas/notarization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9843,16 +9843,28 @@ std::vector<uint256> CPBaaSNotarization::SubmitFinalizedNotarizations(const CRPC
// to prevent funds loss, sort notaries and make sure we are in the top 2 before we try to submit
if (amWitness)
{
// Each notary gets a window of 4 blocks to submit their notarization.
// This prevents multiple notaries from submitting due to propagation delays on Ethereum.
// The window starts from when the notarization was confirmed on this chain, ensuring
// the first notary has a full window from the moment submission becomes possible.
static const uint32_t NOTARY_SUBMISSION_WINDOW_BLOCKS = 4;
uint32_t confirmedHeight = pfirstProofIdxIt->second->GetHeight();
uint32_t windowNumber = (nHeight >= confirmedHeight) ?
(nHeight - confirmedHeight) / NOTARY_SUBMISSION_WINDOW_BLOCKS : 0;

CNativeHashWriter hw;
hw << nHeight;
hw << confirmedHeight;
hw << windowNumber;
uint256 prHash = hw.GetHash();
std::vector<uint160> notaryVec = externalSystem.chainDefinition.notaries;
auto prandom = std::minstd_rand0(UintToArith256(prHash).GetLow64());
shuffle(notaryVec.begin(), notaryVec.end(), prandom);
if (notaryVec[0] != VERUS_NOTARYID)
{
LogPrintf("skipping notarization submission - was not selected for submission lottery (%s selected)\n", EncodeDestination(CIdentityID(notaryVec[0])).c_str());
printf("skipping notarization submission - was not selected for submission lottery (%s selected)\n", EncodeDestination(CIdentityID(notaryVec[0])).c_str());
LogPrintf("skipping notarization submission - was not selected for submission lottery (%s selected, window %u from confirmed height %u)\n",
EncodeDestination(CIdentityID(notaryVec[0])).c_str(), windowNumber, confirmedHeight);
printf("skipping notarization submission - was not selected for submission lottery (%s selected, window %u from confirmed height %u)\n",
EncodeDestination(CIdentityID(notaryVec[0])).c_str(), windowNumber, confirmedHeight);
return retVal;
}
}
Expand Down