-
Notifications
You must be signed in to change notification settings - Fork 0
Description
SmtpServer.debugProtocol is currently not handled anywhere. The code in js_sys.c that used to handle it is commented out and hasn't been ported to Duktape. It also relies on the config global variable, which no longer exists.
To avoid the overhead of looking up the property for every logged message, the property could be read once in smtp_server_main() and then propagated through struct smtp_server_context, which then would have to be passed down to smtp_server_response() instead of just the stream field.
Alternately, SmtpServer.debugProtocol support could be removed altogether, since the SMTP dialogue is logged with the LOG_DEBUG level, so it could be easily filtered out through the log level. In that case, it would have to be removed from the sample config files too.