Skip to content

Commit 7dd8fc6

Browse files
Merge pull request #13 from mindbox-moscow/fix/booleanValuesInXML
correct boolean values in XML
2 parents f71bab8 + 7743a21 commit 7dd8fc6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/XMLHelper/MindboxXMLSerializer.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ private static function getXML(&$xml, array $data)
4747
if (is_array($value)) {
4848
$subNode = $xml->addChild($key);
4949
self::getXML($subNode, $value);
50+
} elseif (is_bool($value)) {
51+
$xml->addChild($key, var_export($value, true));
5052
} else {
5153
$xml->addChild($key, $value);
5254
}

tests/DTO/DTOTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,13 @@ public function asXmlFieldsProvider()
184184
'someDtoField' => $this->getDto(['dto' => 'value']),
185185
],
186186
'<?xml version="1.0" encoding="utf-8"?>
187-
<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>1</someField><someArrayField><field>value</field></someArrayField><someDtoField><dto>value</dto></someDtoField></' . $this->getXmlName() . '>
187+
<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>true</someField><someArrayField><field>value</field></someArrayField><someDtoField><dto>value</dto></someDtoField></' . $this->getXmlName() . '>
188188
',
189189
],
190190
[
191191
['name' => 'Andrew', 'age' => 33, 'someField' => true, 33 => '345'],
192192
'<?xml version="1.0" encoding="utf-8"?>
193-
<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>1</someField><value>345</value></' . $this->getXmlName() . '>
193+
<' . $this->getXmlName() . '><name>Andrew</name><age>33</age><someField>true</someField><value>345</value></' . $this->getXmlName() . '>
194194
',
195195
],
196196
[

0 commit comments

Comments
 (0)