From d2b776b3cdc302efc58c7a2d2227d0685adc42ac Mon Sep 17 00:00:00 2001
From: Julien Francoz <julien@les-tilleuls.coop>
Date: Mon, 7 Oct 2024 12:08:44 +0200
Subject: [PATCH] set minReadySeconds on deployment/statefulset

Allow to set minReadySeconds to wait for an external load balancer to registre the new target before stopping the next pod during a rolling update (AWS ALB for example)
---
 chart/templates/deployment.yaml  | 3 +++
 chart/templates/statefulset.yaml | 3 +++
 chart/values.yaml                | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/chart/templates/deployment.yaml b/chart/templates/deployment.yaml
index 8518cceb..e39bd160 100644
--- a/chart/templates/deployment.yaml
+++ b/chart/templates/deployment.yaml
@@ -11,6 +11,9 @@ metadata:
     {{- toYaml . | nindent 4 }}
   {{- end }}
 spec:
+{{- if .Values.minReadySeconds }}
+  minReadySeconds: {{ .Values.minReadySeconds}}
+{{- end }}
 {{- if not .Values.autoscaling.enabled }}
   replicas: {{ .Values.replicaCount }}
 {{- end }}
diff --git a/chart/templates/statefulset.yaml b/chart/templates/statefulset.yaml
index d62c5f7e..6cae38ee 100644
--- a/chart/templates/statefulset.yaml
+++ b/chart/templates/statefulset.yaml
@@ -12,6 +12,9 @@ metadata:
   {{- end }}
 spec:
   serviceName: {{ include "kube-httpcache.fullname" . }}
+{{- if .Values.minReadySeconds }}
+  minReadySeconds: {{ .Values.minReadySeconds}}
+{{- end }}
 {{- if not .Values.autoscaling.enabled }}
   replicas: {{ .Values.replicaCount }}
 {{- end }}
diff --git a/chart/values.yaml b/chart/values.yaml
index 688554bf..d2c6f49b 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -13,6 +13,9 @@ imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
+# leave time to external load balancer to register target before terminating next Pod
+minReadySeconds: 0
+
 # Enable StatefulSet (Deployment is default)
 useStatefulset:
   enabled: true