Skip to content

xPDO->addPackage returns true even if xPDO->setPackageMeta fails #145

@Mark-H

Description

@Mark-H

In https://github.com/modxcms/xpdo/blob/3.x/src/xPDO/xPDO.php#L474-L476, changing $added = true; to $added = $this->setPackageMeta will allow calls to addPackage to get the proper true/false dependant on the actual success.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions