Skip to content

Review by tenntenn #4

@tenntenn

Description

@tenntenn

https://github.com/moricho/tparallel/blob/master/tparallel.go#L15
いい感じのコメントを書いたほうが良さそう

https://github.com/moricho/tparallel/blob/master/tparallel.go#L34
非公開な型に依存すると将来壊れる可能性あるのでtypes.LookupFieldOrMethodを使った方がよさそう。
参考:https://docs.google.com/presentation/d/1I4pHnzV2dFOMbRcpA-XD0TaLcX6PBKpls6WxGHoMjOg/edit#slide=id.g80c1410104_5_250

https://github.com/moricho/tparallel/blob/master/tparallel.go#L43
よいコメント 👍

https://github.com/moricho/tparallel/blob/master/tparallel.go#L89
先頭の命令だけで良さそう

よくかけてて良いですね!!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions