-
Notifications
You must be signed in to change notification settings - Fork 42
Milestone badge webhook weirdness #124
Description
This may be due to my daft issuer test implementation not being correctly designed and/or may be related to this post on the Dev group https://groups.google.com/forum/#!topic/openbadges-dev/NzEpb_06ypM
I'm finding that when a milestone badge is automatically issued, the badge data is sometimes duplicated at the webhook. i.e. If I have a milestone badge which is issued when an earner is issued two other badges, the webhook does fire three times, but the webhook receives the same data more than once.
e.g.
- "Great Swimmer" and "Great Diver" cause milestone badge "Great in Water" to be awarded.
- The three badge instances are correctly created (in the db and the assertion files) and the webhook receives data three times.
- _However, the webhook doesn't receive different data each of the three times it fires, it receives data for the same badge 2 or 3 times (and so doesn't receive the data for 1/2 the issued badges at all..)_
- e.g. The webhook fires twice with "Great Swimmer" and once with "Great Diver" but not at all with "Great in Water".
Hope that makes sense.. If this is likely to have been caused by a flaw in my webhook logic please let me know so that I can advise people likewise - it basically does what I've described here: https://github.com/mozilla/badgekit-api/wiki/Badge-Issued-Webhooks#processing-the-award-data
Thanks 😸