-
Notifications
You must be signed in to change notification settings - Fork 231
Open
Description
The issue fixed in #153 was introduced again in #582. Now the browser global can be overriden by a DOM element if there is either browser.runtime.id or exports:
| if (!(globalThis.browser && globalThis.browser.runtime && globalThis.browser.runtime.id)) { |
<form id="browser"></form>
<form id="browser" name="runtime"></form>| } else if (typeof exports !== "undefined") { |
<form id="exports">This can be fixed by checking that browser.runtime.id and exports are of the correct type, e.g. are not instances of HTMLElement or HTMLCollection.
Credit: discovered by me and skadi.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels