Strategies still emit debug statements even with log_results config set to false

[ddresselhaus]

Using the DNS strategy, I'm still getting debug statements even with the log_results config set to false.

I'd like to wrap this line:

peerage/lib/peerage/dns.ex

Line 37 in 76ac9f6

Logger.debug " -> Peerage.Via.Dns resolved '#{hostname()}' to #{ to_s(ip) } "

and possibly also this line (UDP):

peerage/lib/peerage/udp.ex

Line 65 in 76ac9f6

Logger.debug " -> Peerage.Via.Udp sees: #{ name }"

in a conditional, checking the log_results config. I'm happy to submit a PR, if there's interest in having this done.

[a12e]

Hello,

This is a good idea! Peerage is polluting my dev console :/

[Faolain]

@mrluc any thoughts on this?

[mrluc]

Whoops, this was forgotten about.

1. It would be great to have this behind a config option.
2. For right now, I've just used logger's :compile_time_purge option if I want to silence it in dev; granular example from Logger docs:

    config :logger,
      compile_time_purge_matching: [
        [application: :foo],
        [module: Bar, function: "foo/3", level_lower_than: :error]
      ]

[Faolain]

thanks @mrluc!

@ddresselhaus if you've already done this do you mind submitting a PR?

[ddresselhaus]

Cool. Submitted here: https://github.com/mrluc/peerage/pull/23/commits

[ddresselhaus]

@mrluc any thoughts? ^^^^

[cpursley]

@ddresselhaus ~ your branch does not seem to be working for me. Still getting bombarded with these logs:

-> Peerage.Via.Dns resolved ...

[ddresselhaus]

@cpursley are you setting log_results to false in the peerage config?

[cpursley]

Yep, sure am.