[BUG] changeDetection property incorrectly flagged as invalid (Angular LSP v0.0.4)

[ArtroxGabriel]

When using Angular’s ChangeDetectionStrategy inside a component decorator, the Angular LSP incorrectly flags the property as invalid.

Example code:

@Component({
  selector: 'app-example-comp',
  templateUrl: './example.component.html',
  styleUrl: './example.component.scss',
  changeDetection: ChangeDetectionStrategy.OnPush,
})
export class ExampleComponent {}

Error shown:

changeDetection must be a member of ChangeDetectionStrategy enum from @angular/core
Value is of type 'ChangeDetectionStrategy$1'. (-991010)

LSP request/response log:

// Send:
{"jsonrpc":"2.0","id":55,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"file:///home/gabrigas/example/src/app/example/example.component.ts"},"range":{"start":{"line":13,"character":49},"end":{"line":13,"character":49}},"context":{"diagnostics":[{"range":{"start":{"line":13,"character":19},"end":{"line":13,"character":49}},"severity":1,"code":-991010,"message":"changeDetection must be a member of ChangeDetectionStrategy enum from @angular/core\n  Value is of type 'ChangeDetectionStrategy$1'."}],"only":["quickfix"]}}}

// Receive:
{"jsonrpc":"2.0","id":55,"result":[]}

Environment:

• Angular LSP version: v0.0.4
• Zed version: Zed 0.200.5 – /usr/lib/zed/zed-editor
• Angular version: 19.2.15

Expected behavior:
The LSP should recognize ChangeDetectionStrategy.OnPush as a valid enum member without raising an error.

Actual behavior:
The LSP incorrectly reports that the value is not a valid member, blocking proper diagnostics.

[jpike88]

can you try to update angular to the latest version and see if the issue persists?

[ArtroxGabriel]

I just tested this again with a more recent Angular version, and the same error still occurs.

Angular Version:

Angular CLI: 20.3.1
Node: 24.8.0
Package Manager: npm 11.6.0
OS: linux x64

Angular: 20.3.0
... common, compiler, compiler-cli, core, forms
... platform-browser, platform-server, router

Package                      Version
------------------------------------
@angular-devkit/architect    0.2003.1
@angular-devkit/core         20.3.1
@angular-devkit/schematics   20.3.1
@angular/build               20.3.1
@angular/cli                 20.3.1
@angular/ssr                 20.3.1
@schematics/angular          20.3.1
rxjs                         7.8.2
typescript                   5.9.2

LSP Output:

{
  "jsonrpc": "2.0",
  "id": 89,
  "method": "textDocument/codeAction",
  "params": {
    "textDocument": {
      "uri": "file:///tmp/app/src/app/example/example.component.ts"
    },
    "range": {
      "start": {
        "line": 7,
        "character": 19
      },
      "end": {
        "line": 7,
        "character": 19
      }
    },
    "context": {
      "diagnostics": [
        {
          "range": {
            "start": {
              "line": 7,
              "character": 19
            },
            "end": {
              "line": 7,
              "character": 49
            }
          },
          "severity": 1,
          "code": -991010,
          "message": "changeDetection must be a member of ChangeDetectionStrategy enum from @angular/core\n  Value could not be determined statically."
        },
        {
          "range": {
            "start": {
              "line": 7,
              "character": 19
            },
            "end": {
              "line": 7,
              "character": 42
            }
          },
          "severity": 1,
          "code": 2304,
          "source": "ts",
          "message": "Cannot find name 'ChangeDetectionStrategy'."
        },
        {
          "range": {
            "start": {
              "line": 7,
              "character": 19
            },
            "end": {
              "line": 7,
              "character": 42
            }
          },
          "severity": 1,
          "code": 2304,
          "source": "typescript",
          "message": "Cannot find name 'ChangeDetectionStrategy'."
        },
        {
          "range": {
            "start": {
              "line": 7,
              "character": 19
            },
            "end": {
              "line": 7,
              "character": 42
            }
          },
          "severity": 3,
          "code": -991010,
          "message": "Unknown reference."
        }
      ],
      "only": [
        "quickfix"
      ]
    }
  }
}

[notpeter]

@ArtroxGabriel Which version of the angular langauge server are you using? Is it possible you have an outdated version in your path or some such?

Do you know if this is also flagged in VSCode?
If it works correctly in vscode but not Zed, I would definitely confirm that both are running the same LSP and if there is any difference in initialization options between VSCode and Zed.

This sounds like an upstream issue with the angular LSP. I don't think this is likely an issue with Zed (it doesn't know anything about Angular and relies on the LSP) or this extension. Unless perhaps there are different settings/initialization options which should be added to the default lsp settings.

[ArtroxGabriel]

Hi, @notpeter

Which version of the angular langauge server are you using? Is it possible you have an outdated version in your path or some such?

I need to verify, but already answering you, I just installed the angular extension in the zed extension library, angular v0.0.4

Do you know if this is also flagged in VSCode?
If it works correctly in vscode but not Zed, I would definitely confirm that both are running the same LSP and if there is any difference in initialization options between VSCode and Zed.

No, this error don't occur in VSCode using the angular language service

I'm not at my computer right now. As soon as I am, I'll check the LSP versions in both zed and VSCode.

[notpeter]

From the README.md

---

Currently it defaults to 19.0.4

zed-angular/src/angular.rs

Lines 9 to 11 in c299149

	// The Latest version of typescript isn't always compatible with angular see: https://angular.dev/reference/versions#unsupported-angular-versions
	const DEFAULT_ANGULAR_LANGUAGE_SERVER_VERSION: &str = "19.0.4";
	const DEFAULT_TYPESCRIPT_VERSION: &str = "5.7.3";

Are you explicitly setting a version of the @angular/language-service via settings.json to 20.3.0?

P.S. I'm not an Angular user; I work at Zed on the Open Source team. In general we prefer to have extensions automatically use the latest release on GitHub, but I believe it was pinned for this extension in response to specific new releases breaking functionality. We should probably add some better docs for Angular in the Zed TypeScript Language Docs.

[ArtroxGabriel]

Are you explicitly setting a version of the @angular/language-service via settings.json to 20.3.0?

I am not explicitly setting the version of @angular/language-service to 20.3.0 in my settings.json file. I also attempted to manually set it to 19.0.4, but that did not resolve the issue.

I have also tried installing the dev extensions, and the same error persists.

[jpike88]

I actually recall having the issue earlier in the year. I had this set in my .zed/settings.json and things have worked fine since. The bug you're seeing is still present because it's a reflection of the angular package that this extension downloads, not your own project's version.

@nathansbradshaw I think it's better if we don't pin angular to such an old version, and we just ensure the typescript version is only as recent as the language services dependency allows. People should be encouraged to update to the latest version of angular/ts before flagging any bugs, as beyond this particular issue there aren't any other glaring backwards compat problems. This will match parity with the offical VSCode extension, and considering how stable v20 and v21 is going to be relative to the past, this shouldn't be a problem.

"lsp": {
		"angular": {
			"initialization_options": {
				"angular_language_service_version": "latest",
				"typescript_version": "latest"
			}
		}
	}

[nathansbradshaw]

@jpike88 When I had originally pinned the versions it was because angular had not updated to the latest typescript, there becomes parity issues when one updates and the other doesn't. I agree, It's an annoying aspect of this plugin. If there is a way to set angular to latest and typescript dynamically gets set to the latest supported version, then that would work, otherwise we do what @notpeter suggested and update the docs to include the information found here: https://angular.dev/reference/versions

Note: it's possible I am working with outdated information, since I haven't worked on an angular project at work in over a year now.

[jpike88]

I suggest download angular first, get the version of the typescript depedency in the package.json, and use that version in npm_install_package to download the target typescript package.

[jpike88]

actually because the package.json doesn't contain the require info, we can get the als_version variables and pass it to a command like this, as they're always released together:

npm view @angular/compiler-cli peerDependencies

this will return the typescript version to analyze and decide what to download

[riker09]

I switched to a Mac today and would like to use Zed as my DE. I stumbled across this issue. I can confirm that it's not occurring on VScode on Windows. I haven't installed VScode on the new Mac, yet. But it's there in Zed.

[jpike88]

@Riker current known workaround is to get angular to a recent enough version that it's ok to pin the extensions angular and typescript versions to 'latest' what's your local version of angular?

[riker09]

Using latest version of Angular 19 (so 19.2.15)

[matthiaskomarek]

an alternative would be to check the projects package.json to find the specified version of @angular/core and use this for the version of the lsp to install. typescript would be compatible out of the box, because it needs to be installed in the correct version for angular to run.

if the lookup fails, it could fallback to the hardcoded lsp + typescript versions