From e439dde7186645864c5c775a3c79eda3e80fca7a Mon Sep 17 00:00:00 2001 From: Craig Gidney Date: Mon, 18 Nov 2013 17:44:10 -0400 Subject: [PATCH 1/2] Fixed 'implementing a method which will also be implemented by its primary class' warning The 'handleAction' method was declared in UIGestureRecognizer+'' but implemented by UIGestureRecognizer+FTBlockAdditions I fixed the warning by removing the apparently spurious declaration, and also the whole UIGestureRecognizer+'' declaration since it only had the one declaration and is not implemented anywhere. --- Classes/FTUtils+UIGestureRecognizer.m | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Classes/FTUtils+UIGestureRecognizer.m b/Classes/FTUtils+UIGestureRecognizer.m index 0d01de5..3c4383a 100644 --- a/Classes/FTUtils+UIGestureRecognizer.m +++ b/Classes/FTUtils+UIGestureRecognizer.m @@ -27,12 +27,6 @@ of this software and associated documentation files (the "Software"), to deal #import "FTUtils+UIGestureRecognizer.h" #import -@interface UIGestureRecognizer() - -- (void)handleAction:(UIGestureRecognizer *)recognizer; - -@end - static char * kFTGestureActionKey = "ft_gestureAction"; static char * kFTGestureDisabledKey = "ft_gestureDisabled"; @@ -73,4 +67,4 @@ - (void)setDisabled:(BOOL)disabled { @end -#endif \ No newline at end of file +#endif From d4b02a335b74f357b7f4bb39182cbeca3ef74ad3 Mon Sep 17 00:00:00 2001 From: Skotch Vail Date: Wed, 20 Nov 2013 18:46:24 -0800 Subject: [PATCH 2/2] Fixed warnings related to incorrect documentation parameters Also explicitly made property atomic, since the compiler was assuming as much --- Headers/FTUtils/FTAnimation+UIView.h | 20 ++++++++----------- Headers/FTUtils/FTAnimationManager.h | 2 +- Headers/FTUtils/FTUtils+UIGestureRecognizer.h | 2 +- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/Headers/FTUtils/FTAnimation+UIView.h b/Headers/FTUtils/FTAnimation+UIView.h index 0b258ab..5be6ce7 100644 --- a/Headers/FTUtils/FTAnimation+UIView.h +++ b/Headers/FTUtils/FTAnimation+UIView.h @@ -54,7 +54,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)slideInFrom:(FTAnimationDirection)direction duration:(NSTimeInterval)duration delegate:(id)delegate @@ -80,7 +80,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)slideOutTo:(FTAnimationDirection)direction duration:(NSTimeInterval)duration delegate:(id)delegate @@ -116,7 +116,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)backOutTo:(FTAnimationDirection)direction withFade:(BOOL)fade duration:(NSTimeInterval)duration delegate:(id)delegate @@ -144,7 +144,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)backInFrom:(FTAnimationDirection)direction withFade:(BOOL)fade duration:(NSTimeInterval)duration delegate:(id)delegate @@ -171,7 +171,6 @@ /** Causes the view to fade in from invisible to fully opaque. - @param direction The edge or corner of the screen where animation will end. @param duration The duration (in seconds) of the animation. @param delegate The *delegate* will be forwarded the standard `CAAnimationDelegate` methods. @@ -187,7 +186,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)fadeIn:(NSTimeInterval)duration delegate:(id)delegate startSelector:(SEL)startSelector stopSelector:(SEL)stopSelector; @@ -195,7 +194,6 @@ /** Causes the view to fade out until it is invisible. - @param direction The edge or corner of the screen where animation will end. @param duration The duration (in seconds) of the animation. @param delegate The *delegate* will be forwarded the standard `CAAnimationDelegate` methods. @@ -211,7 +209,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)fadeOut:(NSTimeInterval)duration delegate:(id)delegate startSelector:(SEL)startSelector stopSelector:(SEL)stopSelector; @@ -220,7 +218,6 @@ Causes the background color of the view to fade in from invisible to completely opaque. - @param direction The edge or corner of the screen where animation will end. @param duration The duration (in seconds) of the animation. @param delegate The *delegate* will be forwarded the standard `CAAnimationDelegate` methods. @@ -237,7 +234,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)fadeBackgroundColorIn:(NSTimeInterval)duration delegate:(id)delegate @@ -246,7 +243,6 @@ /** Causes the background color of the view to fade out until it is invisible. - @param direction The edge or corner of the screen where animation will end. @param duration The duration (in seconds) of the animation. @param delegate The *delegate* will be forwarded the standard `CAAnimationDelegate` methods. @@ -262,7 +258,7 @@ neither message will be sent. @param startSelector A selector to be messaged on *delegate* right before the start of the animation. This parameter can be `nil`. - @param startSelector A selector to be messaged on *delegate* after the animation has + @param stopSelector A selector to be messaged on *delegate* after the animation has finished normally or been cancelled. This parameter can be `nil`. */ - (void)fadeBackgroundColorOut:(NSTimeInterval)duration delegate:(id)delegate diff --git a/Headers/FTUtils/FTAnimationManager.h b/Headers/FTUtils/FTAnimationManager.h index be13900..37aea55 100644 --- a/Headers/FTUtils/FTAnimationManager.h +++ b/Headers/FTUtils/FTAnimationManager.h @@ -180,7 +180,7 @@ static inline CGPoint FTAnimationOffscreenCenterPoint(CGRect viewFrame, CGPoint The maximum value (in points) that the bouncing animations will travel past their end value before coming to rest. The default is 10.0. */ -@property(assign) CGFloat overshootThreshold; +@property(atomic, assign) CGFloat overshootThreshold; ///--------------------------------------------------------------------------- /// @name Accessing the animation manager diff --git a/Headers/FTUtils/FTUtils+UIGestureRecognizer.h b/Headers/FTUtils/FTUtils+UIGestureRecognizer.h index da42b7f..762f1f4 100644 --- a/Headers/FTUtils/FTUtils+UIGestureRecognizer.h +++ b/Headers/FTUtils/FTUtils+UIGestureRecognizer.h @@ -89,4 +89,4 @@ typedef void (^FTGestureActionBlock)(id recognizer); @end -#endif \ No newline at end of file +#endif