-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
It was discovered that the neuvector is using dayjs without explicitly listing it as a dependency during an update to Vue 3.5 (rancher/dashboard#13085). This appeared to be causing issues with the plugin tests, resulting in the following error for neuvector:
- Building for production as library (umd-min)...
[BABEL] Note: The code generator has deoptimised the styling of /home/runner/work/dashboard/dashboard/manager-ext/pkg/neuvector-ui-ext/types/neuvector.ts as it exceeds the max of 500KB.
ERROR Failed to compile with 1 error5:49:49 PM
error in utils/common.ts:85:23
TS2694: Namespace 'dayjs' has no exported member 'ManipulateType'.
83 | base: string,
84 | interval: number,
> 85 | intervalUnit: dayjs.ManipulateType,
| ^^^^^^^^^^^^^^
86 | pattern = "YYYYMMDDHHmmss"
87 | ) {
88 | // base format: "YYYYMMDDHHmmss"
In order to resolve this issue, neuvector may need to specify a version of dayjs in the resolution property in package.json.
Additional details
It was also noted that the main branch of the neuvector extension repo did not appear to be up to date with latest changes made to the neuvector. In order to properly test integrations with the neuvector extension in the Dashboard extension, this will also need to be updated regularly.
See comment by @aalves08 in rancher/dashboard#13085 (comment)
Metadata
Metadata
Assignees
Labels
No labels