Added column breaks rancher node list

[richard-cox]

Rancher: v2.12.0
Extension: v2.1.4

• After installing the extension to rancher the UI's nodes list ( --> Cluster group --> Node entry) fails to sort or filter
• This is due to

  manager-ext/pkg/neuvector-ui-ext/index.ts

  Lines 96 to 97 in d2c64cc

  	sort: ['stateSort', 'nameSort'],
  	search: ['stateSort', 'nameSort'],

  • the sort and search properties should be a path to a value within the node OR be disabled by setting them to false

[richard-cox]

The easiest fix here is just set both to false

[xingzhang-suse]

The issue is fixed. It will in v2.1.5

[richard-cox]

@xingzhang-suse thanks for the quick update. i should have been more verbose in the description though.

In v2.12 vai is enabled by default. This feature means server-side pagination is used in a lot of tables, and sorting and filtering is happening server-side.

Because of this the properties that are used to sort + search with vai on must be paths to properties that exist in the resource server-side (and are indexed, more info on request). For vai off world they must be paths on the local resource or it's model.

Unfortunately we discovered a gap in functionality, the dashboard does not currently support extensions providing different table header definitions for both... it only accepts one (to be addressed with rancher/dashboard#15480). So that one header config needs to work with both vai on and off.

From the screenshots it looks like search works, would you also be able to confirm if sort by vulnerabilities works?

From the linked commit it looks like the search is correctly false, however sort is set to a computed property on the component used as a table formatter. that won't work for vai off, and it will cause the same breakage (request fails) if enacted.

[xingzhang-suse]

@richard-cox Yes, indeed it doesn't work when server side pagination is enabled.
I don't find how to set the sort dynamically in a column plugin. I only find it can be reset in paginationHeaders.
So I set the sort into false now. Thank you for your confirmation!

[richard-cox]

@xingzhang-suse no problem, we can let you know when rancher/dashboard#15480 is ready to use (won't be for a while), this would be a good use case to test it with.

[leotseng-suse]

This has been verified in the QA environment. The relevant commits are working as expected.

c.c. @xingzhang-suse @selvamt94