[Bug]: Upgrade to 32.0.6 breaks existing SFTP connections with custom ports

[kylespencer]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Upgrading to 32.06 appears to have introduced a "port" field for SFTP External Storage connections which broke existing SFTP connections with custom ports until the port number was migrated from the hostname field (IP:PORT) to the port field.

This caused directory listings which include SFTP External Storage locations to fail to display in Files with a vague error.

The cause of this problem was not clear from the logs, so I am documenting it here in case anyone else encounters the same problem.

Steps to reproduce

1. Upgrade to 32.06 with SFTP External Storage with a custom port in the hostname field (IP:PORT)
2. Fail to load Files locations when SFTP External Storage is involved

Expected behavior

1. Upgrade to 32.06 with SFTP External Storage with a custom port IP:PORT
2. See Warning message in Administration that recommends migrating the port number to the new field

Nextcloud Server version

32

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 32.0.1 to 32.0.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[solracsf]

Probably related to #57793
Maybe you can revert it (it's a single line of code) and test?

Cc @pac0san

[rtcim]

@kylespencer @solracsf @canadaduane @ruphy @jcfischer You can take a look at our cloud storage software. Click on my avatar to download and test it.There are mobile and computer versions, as well as instant messaging.

[ag-ubrio]

To solve this, you have to add the SFTP-Port in the External Storage Configuration. There is a port-Field under the Host-Field now. Just enter the port number (22, 23 or whatever your SFTP port is), and everything will work.
But of course this should not have happend. Users should not have to change configuration manually on updates.
Is there a possibility to extract the port-numer from the host-field and enter it in the port-field?

[tgeller]

Thank you, @solracsf ! This also fixed the problems I reported at https://help.nextcloud.com/t/file-access-syncing-broken-typeerror-fsockopen-argument-2-port-must-be-of-type-int-string-given/240346 .

[solracsf]

@tgeller have you tested #58350?
If yes, leave a comment at the PR. 👍