Unifies error message

[nibrahim]

No description provided.

[claude]

Code Review

Thank you for working on unifying the error message! The intent to consolidate the help text into a single formatted string is good, but there's a syntax error in the current implementation that will prevent the script from running.

Issues Found

🐛 Critical Bug - Syntax Error (update_domains.py:705-706)

help_message = f"""Usage: {progname} [source_id|strip]
       {progname}          - List all sources", file=sys.stderr)
       {progname} strip    - Remove all managed domain sources"""

Problem: Line 705 contains a stray , file=sys.stderr) fragment inside the f-string literal. This appears to be leftover code from the original print() statements that wasn't fully removed during refactoring.

Impact: This will cause a Python syntax error and the script will fail to run.

Fix: Remove the stray text:

help_message = f"""Usage: {progname} [source_id|strip]
       {progname}          - List all sources
       {progname} strip    - Remove all managed domain sources"""

⚠️ Minor Style Issue (update_domains.py:707)

Missing space after comma in print(help_message,file=sys.stderr)

Recommendation: Add space for PEP 8 compliance:

print(help_message, file=sys.stderr)

Positive Aspects

✅ Good refactoring idea - using sys.argv[0] makes the help message more accurate
✅ F-string usage is appropriate and modern
✅ Multi-line string with proper indentation alignment

Recommendation

Please fix the syntax error on line 705 before merging. Consider running the script with python3 -m py_compile update_domains.py or running it with invalid arguments to catch this type of error during development.

Testing Suggestion

After fixing:

# Should display help message without errors
./update_domains.py invalid_arg

[claude]

PR Review: Unifies error message

Summary

This PR consolidates the usage message from three separate print() statements into a single f-string, making the code cleaner and more maintainable. The change extracts the program name dynamically from sys.argv[0] instead of hardcoding ./update_domains.py.

Positives

1. Improved maintainability: Using a single multi-line string is easier to maintain than multiple print statements
2. Dynamic program name: Using sys.argv[0] makes the help message adapt to how the script is invoked
3. Consistent formatting: The unified approach maintains proper alignment
4. Cleaner code: Reduces line count while improving readability

Minor Observations

1. Inconsistency with show_help(): There is a similar usage message at lines 689-691 that still uses the old hardcoded style. Consider applying the same refactoring to this location for consistency across the codebase.

2. Trailing newline: The old version had an extra newline at the end, but the new version does not. This is fine, but worth noting in case the whitespace was intentional for output formatting.

Code Quality: Good

• The change follows Python best practices
• F-string usage is appropriate and idiomatic (Python 3.6+)
• No bugs introduced
• No security concerns
• No performance impact (trivial code path)

Recommendation: Approve with minor suggestion

This is a solid refactoring that improves code quality. Consider extending the same pattern to the other usage message for consistency, but this can be done in a follow-up PR if preferred.

No blocking issues - safe to merge.