Skip to content

Refactor how CachedCollector handles Closures #11

@tyler-sommer

Description

@tyler-sommer

in src/Router/RouteCollector/CachedCollector.php, line 60

TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    {
        $cache = new ConfigCache($this->cacheFile, $this->debug);
        if (!$cache->isFresh()) {
            $routes = $this->wrappedCollector->getData();

            // TODO: This seems a fragile way to handle this
            if (!$this->isCacheable($routes)) {
                return $routes;
            }

            $cache->write('<?php return '.var_export($routes, true).';');

Posted from SensioLabsInsight

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions