Windows crash when build same model twice

[paul-vdb]

@paciorek Can you check if lines 896-903 run for you in "test-nested-fit.R" or is this a Windows issue?
I'm getting a classic error of R crashing which I assume is an indexing problem. It did not have an issue when ADuseNormality = TRUE in the run above this example, but not when FALSE.

[paul-vdb]

I should also note that I downloaded the newest version of NIMBLE from devel this morning, not the CRAN one.

[paciorek]

This has been passing CI testing (at least on Linux) and is fine on my machine.

CI on MacOS has been timing out so I'm not 100% sure it's ok on MacOS, but I think it is.

[paul-vdb]

@paciorek I'm having the same issue with the LKJ example so I'm putting this down to specifically to ADuseNormality = FALSE. Did you want to do a call about this or are you able to follow up on a Windows machine? I am not very familiar with these changes.

[paciorek]

I should have said earlier that those tests with ADuseNormality=FALSE are running just fine on Windows under CI.

So I think things are ok. I'm not sure what is going wrong on your machine, but I'm inclined to proceed with the release.

Does the code crash on your machine if you just run the Wishart (or LKJ) example outside of a testing situation?

[paul-vdb]

@paciorek I've figured out what is going on here to some degree. This is a windows error that does not seem to be due to testthat. I think a related error is happening when we build the same model twice (maybe without any reset = TRUE). Everything seems to run fine doing that except result$improveParamMarginals(1:7, nMarginalGrid=5).

In short, I can't run the two versions without crashing, but only the improve marginals crashes it. No issue specifically related to ADuseNormality, but seems to be due to setting up a model for a second time in a single session.

I will leave close for now, but I think we need to circle back on why this is happening.

Otherwise, all tests are passed on Windows and things look good.

[paciorek]

Let's leave this (renamed) issue open.