This repository was archived by the owner on Dec 12, 2025. It is now read-only.
expander: add support for vlan tags, truncate iface name #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the expander does not support adding a ".100" vlan
id to the end of a capture referenced ethernet interface name when
creating a vlan interface.
Example: "{{ capture.nic.interfaces.0.name }}.100"
Resolves: https://issues.redhat.com/browse/NMT-1510
Signed-off-by: Rahul Rajesh <rajeshrah22@gmail.com>
Author
|
Submitting for early feedback. Need to add truncating logic. |
Member
|
@rajeshrah22 currently kubernetes-nmstate is not using this implementation, is using the implemtation at nmstatectl policy, refer to github.com/nmstate/nmstate to open an issue for this. |
Author
Haha, I realized it after I saw the last update was a couple years ago and then looking into kubernetes-nmstate code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the expander does not support adding a ".100" vlan id to the end of a capture referenced ethernet interface name when creating a vlan interface.
Example: "{{ capture.nic.interfaces.0.name }}.100"
Need to add code to truncate interface to 15 characters as per Linux kernel guidelines.
Resolves: https://issues.redhat.com/browse/NMT-1510