-
-
Notifications
You must be signed in to change notification settings - Fork 525
Open
Milestone
Description
Currently node::MakeCallback() returns Local<Value>. This is problematic for two reasons:
node::AsyncWrap::MakeCallback()returns aLocal<Value>()if there's an exception. While the PR hasn't been done, before v6 it will return aMaybeLocal<Value>.- Recursive
MakeCallback()calls depends on knowing if an exception was thrown. This is impossible to do sinceUndefined()is a valid return value.
It should be easy to get around this for backwards compatibility, but would like to make sure nan is ready for the change.
/cc @nodejs/addon-api
Metadata
Metadata
Assignees
Labels
No labels