Skip to content

node::MakeCallback() API change for v6 #548

@trevnorris

Description

@trevnorris

Currently node::MakeCallback() returns Local<Value>. This is problematic for two reasons:

  1. node::AsyncWrap::MakeCallback() returns a Local<Value>() if there's an exception. While the PR hasn't been done, before v6 it will return a MaybeLocal<Value>.
  2. Recursive MakeCallback() calls depends on knowing if an exception was thrown. This is impossible to do since Undefined() is a valid return value.

It should be easy to get around this for backwards compatibility, but would like to make sure nan is ready for the change.

/cc @nodejs/addon-api

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions