Repository constructor with only firebase config

[ZaynJarvis]

Will it be better to use one field constructor?
e.g. In artwork repo
For client side code:

export function getArtworks() {
  const pplRepo = new PeopleRepository(FirebaseApp);
  const awRepo = new ArtworksRepository(FirebaseApp, pplRepo);
  // ...
}

export async function createArtwork(artwork) {
  const pplRepo = new PeopleRepository(FirebaseApp);
  const awRepo = new ArtworksRepository(FirebaseApp, pplRepo);
  // ...

Instead const pplRepo = new PeopleRepository(FirebaseApp); can be created from the library or as a optional field.

[clarencecastillo]

This might just make importing repositories easier. Do you have an example which shows this? Not sure if my understanding is correct, but I fear this will result in a lot of duplicate code.

If it's not a blocker, we can put this one in the backlog first since it's just optimising something that works. Also, what's the difference or relation with #17?

[ZaynJarvis]

Since I notice that config is using across all repos why don’t we use inner class so that all repos will be able to fetch data from other repos. So we use FirebaseRepo.artworkRepo to construct a instance. The other issue temps to discuss this possibility in a sense that no config shall be used. Didn’t think through tho.

…

Sent from my iPhone

On Feb 11, 2019, at 23:55, Clarence Castillo ***@***.***> wrote: This might just make importing repositories easier. Do you have an example which shows this? Not sure if my understanding is correct, but I fear this will result in a lot of duplicate code. If it's not a blocker, we can put this one in the backlog first since it's just optimising something that works. Also, what's the difference or relation with #17? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.