ia32 runtime for x64 darwin system breaks native plugins

[konsumer]

There used to not be a x64-darwin version of node-webkit runtime, but this has been fixed.

I have a simple test app.

First I make the node-webkit version of the native lib:

npm install
cd node_modules/serialport/
node-pre-gyp rebuild --runtime=node-webkit --target=0.11.2

It builds for darwin | x64 (as it should, since I am on x64)

Since serialport has it's own old copy of node-gyp, it screws up the dir name. There is an issue about that, and hopefully this step won't be needed in the future. So, I rename it to what it's looking for:

mv node_modules/serialport/build/serialport/v1.4.6/Release/node-webkit-v0.11.2-darwin-x64/ node_modules/serialport/build/serialport/v1.4.6/Release/node-webkit-v14-darwin-x64/

If I run this resulting app using the x64 runtime, it works fine:

~/Downloads/node-webkit-v0.11.2-osx-x64\ 2/node-webkit.app/Contents/MacOS/node-webkit .

If I make an app that uses serialport (native module) on my mac, I see that node-webkit-builder downloads the ia32 runtime and the native libs have the wrong version when I run nwbuild -r . I could use a node-pre-gyp rebuild --runtime=node-webkit --target=0.11.2 --target_arch=ia32, but since x64 is supported now, maybe that is better.

I am happy to make a PR, if this is something others are concerned about. Maybe I should solve this with more clever build-scripts, instead (build native modules for each platform's runtime) I am not sure.

[adam-lynch]

So are you saying that if node-webkit-builder supported 64-bit builds this would work? i.e. #114 & #117

[konsumer]

Ah, sorry I didn't see those 2 issues. Yes, if it supported 32bit, it would work.

[adam-lynch]

"if it supported 32bit". I assume that's a typo and you mean 64-bit, right?
Just to be sure. I haven't worked with native modules + node-webkit myself.

On Thu, 11 Dec 2014 19:24 David Konsumer notifications@github.com wrote:

Ah, sorry I didn't see those 2 issues. Yes, if it supported 32bit, it
would work.

—
Reply to this email directly or view it on GitHub
#136 (comment)
.

[konsumer]

Yep, typo. Ideally it would support the correct platform and target, and grab Darwin-x64 on my 64bit Mac.

[konsumer]

Sorry, I was on my phone. I can go into more detail, now. I wonder if it might make sense to just allow the things in process.arch & process.platform directly, with default of "current system" instead of assembling it from tags.

{
  platforms: ['win', 'osx', 'linux32', 'linux64']
}

would become:

{
  platforms: ['win32:ia32', 'darwin:x64', 'linux:ia32', 'linux:x64']
}

I could map them, but that seems less-than-ideal. If the old style is preferred, they could both be supported, so people who need native modules can be a bit more fine-grained about things. I could also see doing something fancy in gulp/grunt to do the node-pre-gyp for all the platforms I want to support, so I could build everything simply from one place:

var gulp = require('gulp'),
  NodePreGyp = require('node-pre-gyp'),
  path = require('path');

var supported =  ['win32:ia32', 'darwin:x64', 'linux:ia32', 'linux:x64'];
var nw_version = '0.11.2';

function pregyp(module, done){
  process.chdir(path.join(__dirname, 'node_modules',module));
  var prog = new NodePreGyp.Run();
  var argv = ['node', 'node-pre-gyp', '--runtime=node-webkit', '--fallback-to-build', '--target=' + nw_version];
  supported.forEach(function(p){
    var plat = p.split(':');
    [ 'install',
      '--target_platform=' + plat[0],
      '--target_arch=' + plat[1]
    ].forEach(function(c){ argv.push(c); });
  });
  console.log(argv.join(' '))
  prog.parseArgv(argv);
  function run(){
    var command = prog.todo.shift();
    if (!command) {
      return done();
    }
    prog.commands[command.name](command.args, function(err){
      if (err) return done(err);
      process.nextTick(run);
    });
  }
  run();
}

gulp.task('runtime', ['fixserial', 'build'], function(done){
  var nw = new NwBuilder({
    files: './build/app/**/**',
    platforms: supported,
    version: nw_version
  });
  nw.build(done);
});
gulp.task('pregyp:serial', function(done){
  pregyp('serialport', done);  
});

This doesn't actually work (I think I am doing something wrong with pre-gyp command-building) but the basic idea is "build node-webkit runtime bound versions of serialport for every supported platform"

Again, I am happy to PR, if you are into this, as a feature. This could maybe even be integrated into the runtime generation process for generating a runtime (scroll through all the modules and pre-gyp them.)

[adam-lynch]

Could you see if 1.0.0 improves this? 64-bit builds are now supported.

Again sorry, I know very little about node-pre-gyp but it seems a little out of the scope of this module.

[konsumer]

Yeh, it might be a bit out of scope, sorry.

I installed -g and found that the CLI bin has a \r in the shebang, which will prevent it from working on POSIX systems.

There is also an error if you use sudo npm install -g with the cache (maybe it should default to system temp dir?):

{ [Error: EACCES, permission denied '/usr/local/lib/node_modules/node-webkit-builder/cache']
  errno: 3,
  code: 'EACCES',
  path: '/usr/local/lib/node_modules/node-webkit-builder/cache',
  syscall: 'mkdir' }

I fixed by taking ownership of /usr/local as my normal user.

After fixing these, I tested and it is indeed downloading correct runtimes & building. Thanks!

I can submit these changes as a PR, if you like.

I will work more on streamlining the use of native modules (especially serial) and point to documentation, if you like.

[adam-lynch]

Wow, sorry I didn't reply here. Yes, PRs for these problems would be good:

I installed -g and found that the CLI bin has a \r in the shebang, which will prevent it from working on POSIX systems.

There is also an error if you use sudo npm install -g with the cache (maybe it should default to system temp dir?):