Update POK value to be nullable

Author: voytas

src/Spectron.Files/Pok/PokeFile.cs

@@ -6,9 +6,9 @@ namespace OldBit.Spectron.Files.Pok;
 /// <param name="MemoryBank">Bits 0-2 specify a memory bank for 128K games or bit 3
 /// is always set for 48K games</param>
 /// <param name="Address">The address (16384-65535).</param>
-/// <param name="Value">Poke value (0-255). If it is 256, a requester should pop up where the user can enter a value</param>
+/// <param name="Value">Poke value (0-255). If it is null, a requester should pop up where the user can enter a value.</param>
 /// <param name="OriginalValue">Original value at the address.</param>
-public record Poke(int MemoryBank, Word Address, int Value, byte OriginalValue);
+public record Poke(int MemoryBank, Word Address, byte? Value, byte OriginalValue);
 
 /// <summary>
 /// Represents a trainer that contains a list of pokes.
@@ -123,7 +123,7 @@ public static PokeFile Load(Stream stream)
             return null;
         }
 
-        return new Poke(memoryBank, address, value, originalValue);
+        return new Poke(memoryBank, address, value > 255 ? null : (byte)value, originalValue);
     }
 
     private static bool IsNextTrainer(string line) => line.StartsWith('N');

tests/Spectron.Files.Tests/Pok/PokeFileTests.cs

@@ -16,7 +16,7 @@ public void PokFile_ShouldLoad()
         pokeFile.Trainers[0].Pokes.Count.ShouldBe(1);
         pokeFile.Trainers[0].Pokes[0].MemoryBank.ShouldBe(8);
         pokeFile.Trainers[0].Pokes[0].Address.ShouldBe(35142);
-        pokeFile.Trainers[0].Pokes[0].Value.ShouldBe(0);
+        pokeFile.Trainers[0].Pokes[0].Value.ShouldBe((byte)0);
         pokeFile.Trainers[0].Pokes[0].OriginalValue.ShouldBe(0);
 
         pokeFile.Trainers[1].Name.ShouldBe("Air supply (Bug Byte)");
@@ -26,14 +26,14 @@ public void PokFile_ShouldLoad()
         pokeFile.Trainers[4].Pokes.Count.ShouldBe(1);
         pokeFile.Trainers[4].Pokes[0].MemoryBank.ShouldBe(8);
         pokeFile.Trainers[4].Pokes[0].Address.ShouldBe(35136);
-        pokeFile.Trainers[4].Pokes[0].Value.ShouldBe(0);
+        pokeFile.Trainers[4].Pokes[0].Value.ShouldBe((byte)0);
         pokeFile.Trainers[4].Pokes[0].OriginalValue.ShouldBe(53);
 
         pokeFile.Trainers[65].Name.ShouldBe("Restart game in last visited cavern(Software Projects)");
         pokeFile.Trainers[65].Pokes.Count.ShouldBe(1);
         pokeFile.Trainers[65].Pokes[0].MemoryBank.ShouldBe(8);
         pokeFile.Trainers[65].Pokes[0].Address.ShouldBe(34260);
-        pokeFile.Trainers[65].Pokes[0].Value.ShouldBe(88);
+        pokeFile.Trainers[65].Pokes[0].Value.ShouldBe((byte)88);
         pokeFile.Trainers[65].Pokes[0].OriginalValue.ShouldBe(0);
     }